On Tue, 11 Jun 2024 13:24:48 GMT, Nizar Benalla <nbena...@openjdk.org> wrote:
>> Can I please get a review for this change, that aims to add support for >> Global HTML tags. >> Here is the >> [link](https://cr.openjdk.org/~nbenalla/javadocGlobalAttrs/pkg1/package-summary.html) >> to the generated docs. >> Thanks in advance. > > Nizar Benalla has updated the pull request incrementally with one additional > commit since the last revision: > > Remove classpath exception src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/Checker.java line 695: > 693: // custom "data-*" attributes are also accepted > 694: var attrName=name.toString(); > 695: if (!attrName.startsWith("on") && > !attrName.matches("data-[a-z]+(-[a-z]+)*")){ I understand that `startsWith("on")` precedes this PR. However, it's more permissive than it should be: in reality, there are only 70 global attributes that start with "on". On the other hand, `attrName.matches("data-[a-z]+(-[a-z]+)*")` is less permissive. For example, if I read the XML spec correctly, such an attribute can contain `_` or start with `data-.`. But maybe those checks are good enough? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19652#discussion_r1634890608
