On Thu, 26 Sep 2024 09:48:52 GMT, Hannes Wallnöfer <hann...@openjdk.org> wrote:
>> Please review a simple fix to prevent `java.lang.AssertionError` from being >> thrown when the `javadoc` `-subpackages` option is used with a `-source` >> release that doesn't support modules. > > Hannes Wallnöfer has updated the pull request incrementally with one > additional commit since the last revision: > > Align indentation Sorry for the confusion and any misunderstanding. It was just a bit strange to see use of Modules isInitialized() in a module-related method when handling the case of pre-module values for `-source`. Also, maybe wow for seeing the issue has been around for so long. Thanks for fixing. ------------- Marked as reviewed by jjg (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/21201#pullrequestreview-2332340548
