On Tue, 15 Oct 2024 10:41:43 GMT, Hannes Wallnöfer <hann...@openjdk.org> wrote:
> Please review the removal of code in `DocCommentParser` that created an error > when encountering a spurious "@" character in an HTML attribute value after a > line break. > > The removed code (which was added in its current form in 2012) seemed to > assume that such a "@" character was part of a block tag and therefore an > indication of an unclosed attribute value. However, both line breaks and "@" > are valid characters in HTML attributes. Note that valid content for HTML > attributes in `DocCommentParser` is [text and entities as per > HTML5][html5-attributes] as well as JavaDoc inline tags, but not block tags. > > [html5-attributes]: > https://html.spec.whatwg.org/multipage/syntax.html#syntax-attribute-value > > The change adds two doctree tests, one to make sure HTML attributes with > mixed values (text, line breaks, entities, inline tags, "@") are parsed > correctly, and a second one to make sure actual unclosed attribute values are > still recognized as errors. Thanks for the context, Jon. I wrote a [lengthy comment][comment] on the JBS issue, unfortunately before I saw your comment above, because it would have answered most of my questions. As explained in my JBS comment I would still consider the current behavior a bug, but I understand why it might be a good idea to do a CSR and spec change. [comment]: https://bugs.openjdk.org/browse/JDK-8321500?focusedId=14713202&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14713202 ------------- PR Comment: https://git.openjdk.org/jdk/pull/21520#issuecomment-2414837003
