On Tue, 29 Oct 2024 11:14:54 GMT, Nizar Benalla <nbena...@openjdk.org> wrote:

> Please review this patch to render javadocs as `<K, V, T>` rather than 
> `<K,V,T>` to match naming conventions and make the rendered output slighly 
> nicer to read.
> 
> Passes langtool tests.
> 
> The[ generated 
> docs](https://cr.openjdk.org/~nbenalla/GeneratedDocs/TypeParams/docs/api/index.html)
>  only includes `java.base/lang`, `java.base/util` and `java.compiler/javax`

Not all reviewers might realise it, but javadoc currently outputs generics both 
ways, with whitespace and without. For example, have a look at [Map.of]. The 
first occurrence of generic parameters (i.e. declaration), immediately after 
the `static` keyword, has whitespace. The second occurrence (i.e. use) does 
not. I think we need to make up our mind on what we should do.

[Map.of]: 
https://docs.oracle.com/en/java/javase/23/docs/api/java.base/java/util/Map.html#of()

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21759#issuecomment-2450259138

Reply via email to