On Thu, 5 Dec 2024 22:36:12 GMT, Justin Lu <j...@openjdk.org> wrote: > Please review this PR which contains the open L10n drop changes for RDP1. > > I recommend viewing the improved diffs which are built out by Jon's tool > here: https://cr.openjdk.org/~jlu/output/. As always, I can not confirm the > correctness on the quality of the translations themselves. > > Generally speaking, observed differences in punctuation can be attributed to > language rules. Any keys requiring localization that came in after the JDK > was submitted for translations will be handled in the RDP2 L10n drop.
Looks generally fine overall. But, looking at the URL for the differences in each file per language, I see changes for `src/jdk.compiler/share/classes/com/sun/tools/javac/resources/launcher`. I don't see any changes for this file in the actual file changes for this PR though. Was there actually a change here? Or some mistake with what was picked up by the diff tool? src/jdk.compiler/share/classes/com/sun/tools/javac/resources/javac_zh_CN.properties line 190: > 188: javac.opt.Xdoclint.package.args = [-]<程序包>(,[-]<程序包>)* > 189: > 190: javac.opt.Xdoclint.package.desc=在特定的程序包中启用或禁用检查。每个 <package> > 是\n限定的程序包名称，或程序包名称前缀后跟 ''.*''\n（这将扩展到给定程序包的所有子程序包）。在每个 <package>\n前面加上 ''-'' > 可对指定程序包禁用检查。 Looks like single-quotes are being changed to double single-quotes for some instances. Is this intentional? Or an issue with how the translation process reads this text? ------------- PR Review: https://git.openjdk.org/jdk/pull/22588#pullrequestreview-2483331030 PR Review Comment: https://git.openjdk.org/jdk/pull/22588#discussion_r1872379231
