On Fri, 20 Dec 2024 17:35:28 GMT, Nizar Benalla <nbena...@openjdk.org> wrote:

>> test/docs/jdk/javadoc/doccheck/doccheckutils/FileProcessor.java line 61:
>> 
>>> 59:             });
>>> 60:         } catch (IOException e) {
>>> 61:             e.printStackTrace();
>> 
>> What's the reason to swallow exceptions here?
>
> I could let the exception propagate, I just didn't think it was interesting.

I think I fixed this in 
[95f61e6](https://github.com/openjdk/jdk/pull/21879/commits/95f61e688eb19b3696c5b342f34f3ff58d733037)
 (alongside a couple other things that popped up when I ran a linter on the 
code).

I know those files exist, so it should really never be thrown.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21879#discussion_r1894315556

Reply via email to