On Tue, 25 Mar 2025 18:39:03 GMT, Jonathan Gibbons <j...@openjdk.org> wrote:
>> Nizar Benalla has updated the pull request incrementally with one additional >> commit since the last revision: >> >> feedback: document params of the factory method. > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/taglets/SnippetTaglet.java > line 199: > >> 197: >> .add(HtmlTree.IMG(pathToRoot.resolve(DocPaths.RESOURCE_FILES) >> 198: >> .resolve(DocPaths.CLIPBOARD_SVG), >> 199: copySnippetText)) > > Not for this PR, but another tiny cleanup would be to add an overload to > `DocPaths.resolve` that takes multiple arguments to be applied (resolve'd) > sequentially Thanks Jon, a quick grep shows 9 places where we call `resolve` multiple times in a single statement. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24204#discussion_r2014067199
