> Can I please get a review of this test-only change which proposes to clean up > some issues noticed in the `TestRedirectLinks.java` test? > > The `javadoc/doclet/testLinkOption/TestRedirectLinks.java` test has been > failing intermittently in our CI. The root cause of those failures isn't yet > clear and those failures are being tracked in > https://bugs.openjdk.org/browse/JDK-8338439. > > While investigating those failures, it was noticed that this test had some > issues that could be addressed separately to rule out their role in the > intermittent failures. > > The commit in this PR updates the test to using existing test library classes > to construct the request URL as well as for constructing the SSLContext. The > test is also updated to use the correct value to represent "no response body" > when calling the `sendResponseHeaders()` method. > > The test continues to pass with this change. We will continue investigating > the intermittent failure if/when it occurs again after this change.
Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision: address review comment in test ------------- Changes: - all: https://git.openjdk.org/jdk/pull/24359/files - new: https://git.openjdk.org/jdk/pull/24359/files/6a919865..c2452bb5 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=24359&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=24359&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/24359.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/24359/head:pull/24359 PR: https://git.openjdk.org/jdk/pull/24359
