On Tue, 10 Jun 2025 07:21:34 GMT, SendaoYan <s...@openjdk.org> wrote:
> Hi all, > > When there is no `tidy` command in PATH, the test > test/docs/jdk/javadoc/doccheck/checks/jdkCheckHtml.java report failure, I > think it shoule be report jtreg.SkippedException rather than report test > failure. > In file test/docs/jdk/javadoc/doccheck/DocCheck.java, we need to call the > `new TidyChecker()` before executing the test so that the > `jtreg.SkippedException` exception can be thrown normally, that's why I add > `new TidyChecker()` in `init()` function. > > Change has been verified locally, only the test > test/docs/jdk/javadoc/doccheck/checks/jdkCheckHtml.java observed this > failure, test-fix only, no risk. Changes look good to me. ------------- Marked as reviewed by hannesw (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/25711#pullrequestreview-2916723187