On Thu, 13 Nov 2025 15:11:57 GMT, Hannes Wallnöfer <[email protected]> wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removing unnecessary imports as suggested.
>
> test/langtools/tools/javac/doctree/ReferenceTest.java line 111:
>
>> 109: * {@link java.base/java.util.Map<String, String>.Entry<String,
>> String>.getKey Bad}
>> 110: * {@link java.base/java.util.Map<String, String>.Entry<String,
>> String>#getKey Bad}
>> 111: * {@link java.base/java.util.Map<String, String>.Entry<String,
>> String>#setValue(Object) Bad}
>
> Is there a reason parameterized types don't work with modules, or is it just
> an implementation quirk? Not that it matters much as it is a rather unlikely
> corner case.
To some degree, in theory, it is only an implementation quirk. In practice, it
is a bit tricky to make that work compatibly enough. I tried here:
https://github.com/lahodaj/jdk/compare/JDK-8371248...lahodaj:jdk:JDK-8371248-full-attribution?expand=1
but it is not perfect.
Unless there are objections, I would like to proceed with the change as it is
here, and then we can see if we can improve the reference attribution.
Thanks!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28272#discussion_r2541108232
