How am I supposed to write spaghetti code if you keep making things immutable and all "good practicy"? There are sometimes when I want everything in one big function. It's nice and simple, and I know where to find everything. Why make things side-effect-free when I know what all the side effects are? Sometimes I just don't understand....
On Mon, Feb 16, 2009 at 10:41 AM, Robert Fischer, Smokejumper Consulting < [email protected]> wrote: > > On Feb 14, 11:22 pm, Reinier Zwitserloot <[email protected]> wrote: > > And when we need to make another modification, we.... rename the > > parameter to 'reallyOldConfigKey'? > > > > To deal with this case (configured once, and then configured again), > you've got four options: > 1) Remove final, which you should train yourself to be a sign you're > probably doing something wrong. > 2) Nest method calls ( translateNewerKeyNames(translateOldKeyNames > (oldConfigKey)) ) > 3) Add another intermediate variable (your "reallyOldConfigKey") > 4) *Refactor the code* so you get one method. > > That pain you're seeing? That weird code smell of > "reallyOldConfigKey"? That's the sign you should be refactoring so > that your increasingly complex parameter mangling can get some unit > tests wrapped around it. That sign is obvious when you're using > "final", but easily obscured when you don't. These kinds of signs are > exactly the reason I'm such a fan of 'final': it rapidly exposes bad > coding practices and points when things should be refactored and > cleaned up. > > ~~ Robert. > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "The Java Posse" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/javaposse?hl=en -~----------~----~----~----~------~----~------~--~---
