Re: [Jaxen] DefaultLcationPath

[Eddie Mc Greal]

after furter investigation  I found the following the reason for the change (1.8 to 1.9) was the following xpath   count(/PLAY/ACT/SCENE[1]) should be 5 and not 1. However, the fix for this problem (made by xcut) is incorrect. The problem is the use of the unique map to filter out identical nodes but /PLAY/ACT/SCENE produces several SCENE nodes. Only adding the first one leads to the bug that count only finds 1 instead of 5. I've removed the unique map (any objections? why was it used in the first place?) and checked it in. All test pass including count(/PLAY/ACT/SCENE[1]) Eddie ----- Original Message ----- From: Eddie Mc Greal To: [EMAIL PROTECTED] Sent: Friday, May 03, 2002 2:27 PM Subject: [Jaxen] DefaultLcationPath Hi,   looking at the current version of our DefaultLocationPath I think I spotted a problem - In version 1.8 we applied a Step to a list of nodes, then applied any predicates to this producting a new list. We then moved on to the next step repeating the process etc. In version 1.9 this has changed to applying the predicates to each node as it is returned from the step iterator. I think this is wrong as then the position is lost so things like /name[10] will never work. If that is the case then I don't how the test cases are passing Eddie