Jochen Wiedmann wrote:

The only points I dislike with your solution is, that you'd defer the
use of the DatatypeConverter to compile time. Whereever possible, the
DatatypeConverter should be used at generation time. I do not know, if
this is currently always the case. However, it is the case (for
example) in the LongSG.



I understand and I totally agree that this is much more user friendly. So we then have two choices:

1. Do like LongSG does for all other simple types
2. Have a bunch of if's in TypedValueImpl's write method to distinguish from different types and generate accordingly


Since there is already a method for this on every simple type and it is how it's being done (almost) everywhere it would probably be safer (1). The issue here is how Enumerations handle this: they expect TypedValue to do the conversion. So, which one to choose? Really, having TypedValue do the conversion would have a centralized place for this kind of stuff. So, I'm not sure which way to go. If I was to decide I'd choose 2. What do you think?

Two more points:

1. DataTypeConverter is not really needed then?
2. getCastFromString(SimpleTypeSG pController, JavaMethod pMethod, Object pValue, Object pData) would no longer be needed?


Thanks

Nacho



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to