Cool, both JBEHAVE-1103 and JBEHAVE-1104 have now been released in 4.0.2.
On 17/07/2015 15:24, Rafael Jimenez wrote:
Hi Mauro,
I agree using a programmatically approach is more than enough.
Actually I usually prefer it.
Regarding the implementation itself, I was even thinking in a much
simpler solution, i.e. allow to define one custom implementation.
However with your approach the solution is much more powerful, as it
allows as many meta prefixes as needed, great job!
Best Regards,
Rafa.
El viernes, 17 de julio de 2015, 12:54:39 (UTC+2), mauro.talevi escribió:
I too don't like reflection much. So, as an initial step, I've
allowed the configuration of the instances programmatically via
the Embedder (which passes it on to the MetaFilter).
If want to also have the configuration of the instances specified
in other forms, e.g. for annotation-based configuration, then we'd
need to go down the route of reflection.
For most users, the programmatic option will suffice, as the
matcher is like a reporter, you configure it once and you tend to
forget about it. There is no need to reconfigure it at each
execution.
Anyway, please checkout latest snapshot and let us have your
thoughts.
Cheers
On 16/07/2015 19:06, Rafael Jimenez wrote:
Hi Mauro,
First of all thank you.
I've created https://jbehave.atlassian.net/browse/JBEHAVE-1104
with the Feature Request although it is not needed for me since
you merged and pushed the changes.
Regarding the possible implementation, I don't really like too
much reflection, but I cannot think in a possible implementation
yet. I don't know yet too much of JBehave's implementation.
Best Regards,
Rafa.
El jueves, 16 de julio de 2015, 18:13:36 (UTC+2), mauro.talevi
escribió:
Hi Rafa,
Thanks for the PR, it has been merged and pushed.
As for the idea to make the matcher configurable, I agree it
may also come in handy at times.
We just need to agree the convention to pass in the matcher
class to instantiate, e.g.
[com.example.matchers.CustomMatcher]: the string to match
WDYT? Please raise another JIRA issue for this.
Cheers
On 16/07/2015 18:04, Rafael Jimenez wrote:
Previous PR was closed.
New PR https://github.com/jbehave/jbehave-core/pull/86 has
been created, sorry for the inconvenience.
El jueves, 16 de julio de 2015, 17:13:53 (UTC+2), Rafael
Jimenez escribió:
Hi all,
When using JBehave with Gherkin syntax, it is very
useful to be able to use Meta Filters that contains a
Hyphen (-) character.
For instance the following JBehave to Gherkin converter
changes JBehave's '@author somebody' Meta into
'@author-somebody':
https://github.com/adaptive-logic/jbehave-to-gherkin
JBEHAVE-851
<https://jbehave.atlassian.net/browse/JBEHAVE-851> Feature
Request is very similar, however it is not working now,
although was implemented in 3.7.4 version.
I've created a PR
(https://github.com/jbehave/jbehave-core/pull/85) that
changes DefaultMetaMatcher Regular Expression to support
hyphens (among other special characters).
You can have a better look to the regular expression at
https://regex101.com/r/yH5vN4/1
Alternatively, MetaFilter Class could allow custom
implementations of MetaMatcher Interface.
Best Regards,
Rafa.
--
You received this message because you are subscribed to the
Google Groups "JBehave Dev" group.
To unsubscribe from this group and stop receiving emails
from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web, visit
https://groups.google.com/d/msgid/jbehave-dev/4a36906c-a020-4f5f-af3d-7b8160286622%40googlegroups.com
<https://groups.google.com/d/msgid/jbehave-dev/4a36906c-a020-4f5f-af3d-7b8160286622%40googlegroups.com?utm_medium=email&utm_source=footer>.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the
Google Groups "JBehave Dev" group.
To unsubscribe from this group and stop receiving emails from it,
send an email to [email protected] <javascript:>.
To post to this group, send email to [email protected]
<javascript:>.
To view this discussion on the web, visit
https://groups.google.com/d/msgid/jbehave-dev/6b33351f-4eaa-435f-a316-fdeb2a85c04e%40googlegroups.com
<https://groups.google.com/d/msgid/jbehave-dev/6b33351f-4eaa-435f-a316-fdeb2a85c04e%40googlegroups.com?utm_medium=email&utm_source=footer>.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google
Groups "JBehave Dev" group.
To unsubscribe from this group and stop receiving emails from it, send
an email to [email protected]
<mailto:[email protected]>.
To post to this group, send email to [email protected]
<mailto:[email protected]>.
To view this discussion on the web, visit
https://groups.google.com/d/msgid/jbehave-dev/30b6a81e-b2fa-4759-b0b0-a1f7d7b06a7c%40googlegroups.com
<https://groups.google.com/d/msgid/jbehave-dev/30b6a81e-b2fa-4759-b0b0-a1f7d7b06a7c%40googlegroups.com?utm_medium=email&utm_source=footer>.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "JBehave
Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send an email to [email protected].
To view this discussion on the web, visit
https://groups.google.com/d/msgid/jbehave-dev/55A90F0F.4050607%40aquilonia.org.
For more options, visit https://groups.google.com/d/optout.
