I am curious why there are references to org.gjt.lindfors.pattern.StrategyContext in 
the verifier.strategy package.  VerificationContext extends StrategyContext and 
EJBVerifier11.getContext() and EJBVerifier20.getContext() both return StrategyContext. 
 VerificationStrategy extends Strategy just for the getContext() method...

If we need Strategy and StrategyContext, shouldn't we pull it into org.jboss somehow?  
I may be missing something, but looking at the source 
(http://www.gjt.org/servlets/JCVSlet/log/gjt/org/gjt/lindfors/pattern/StrategyContext.java/0)
 I sure don't see any reason that VerificationContext should extend it...

My opinion :

Index: VerificationContext.java
===================================================================
RCS file: /products/cvs/ejboss/jboss/src/main/org/jboss/verifier/strategy/Verifi
cationContext.java,v
retrieving revision 1.1
diff -r1.1 VerificationContext.java
34,35d33
< import org.gjt.lindfors.pattern.StrategyContext;
<
54,55c52
< public interface VerificationContext extends StrategyContext,
<                                              VerificationEventGenerator {
---
> public interface VerificationContext extends VerificationEventGenerator {

Index: EJBVerifier11.java
===================================================================
RCS file: /products/cvs/ejboss/jboss/src/main/org/jboss/verifier/strategy/EJBVer
ifier11.java,v
retrieving revision 1.8
diff -r1.8 EJBVerifier11.java
36,37d35
< import org.gjt.lindfors.pattern.StrategyContext;
<
146c144
<     public StrategyContext getContext() {
---
>     public VerificationContext getContext() {

Index: EJBVerifier20.java
===================================================================
RCS file: /products/cvs/ejboss/jboss/src/main/org/jboss/verifier/strategy/EJBVer
ifier20.java,v
retrieving revision 1.4
diff -r1.4 EJBVerifier20.java
34,35d33
< import org.gjt.lindfors.pattern.StrategyContext;
<
83c81
<     public StrategyContext getContext() {
---
>     public VerificationContext getContext() {

Index: VerificationStrategy.java
===================================================================
RCS file: /products/cvs/ejboss/jboss/src/main/org/jboss/verifier/strategy/Verifi
cationStrategy.java,v
retrieving revision 1.3
diff -r1.3 VerificationStrategy.java
31d30
< import org.gjt.lindfors.pattern.Strategy;
46c45
< public interface VerificationStrategy extends Strategy {
---
> public interface VerificationStrategy {
______________________________________________
FREE Personalized Email at Mail.com
Sign up at http://www.mail.com/?sr=signup


Reply via email to