Actually I agree, I worked it "FastKey" because ALL my entities depend on
it.
I tried to code it Object but there was a problem with the finders and CMP
beans...
I can look again
marc
> -----Original Message-----
> From: [EMAIL PROTECTED]
> [mailto:[EMAIL PROTECTED]]On Behalf Of Hugo Jos� Pinto
> Sent: Thursday, August 17, 2000 11:49 PM
> To: jBoss Developer
> Subject: [jBoss-Dev] Marc (& Rickard): Architecture "tweak"?
>
>
> Hi Marc and Rickard.
>
> Guys,
>
> I noticed that due to marc's change to make FastKey work, the
> ContainerInvoker interface (and some others) was changed, replacing the
> entity's pk for a FastKey instance, like where was
>
> public EJBObject getEntityEJBObject(Object id)
> throws RemoteException;
>
> is now
>
> public EJBObject getEntityEJBObject(FastKey id)
> throws RemoteException;
>
> Isnt't this an architecture tweak? An hack? Is it good to make
> the interface
> domain-specific? Shoudn't we be keeping the "Object id" signature AND, in
> our specific implementation (JRMP), checking at runtime if it is
> "instanceof
> FastKey"?
>
> Pardon me if my opinion feels like a pile of s**t to you - I'm not a jBoss
> codebase guru (yet) anyway - but, however, this feels somewat wrong to me.
> Any comments?
>
> Hugo Pinto
>
>
>
