Aaron Mulder wrote:
AM> What's the problem that you're trying to fix here?
NullPointerException during garbage collection for Connections.
Now fixed: after unsuccessful login or any other SQL error in the
underlying DataSource/driver during getConnection()
an invalid ObjectRecord was put to the pool.
Sorry for hasty commit, I have to adjust my personal timeout.
Best regards,
Oleg
AM> On Mon, 2 Oct 2000, jBoss CVS Development wrote:
>> User: oleg
>> Date: 00/10/02 10:24:07
>>
>> Modified: src/main/org/jboss/minerva/pools ObjectPool.java
>> Log:
>> Rollback of the wrong bugfix. I don't understand, what really goes wrong with GC.
>>
>> Revision Changes Path
>> 1.9 +1 -1 jboss/src/main/org/jboss/minerva/pools/ObjectPool.java
>>
>> Index: ObjectPool.java
>> ===================================================================
>> RCS file:
>/products/cvs/ejboss/jboss/src/main/org/jboss/minerva/pools/ObjectPool.java,v
>> retrieving revision 1.8
>> retrieving revision 1.9
>> diff -u -r1.8 -r1.9
>> --- ObjectPool.java 2000/10/02 17:11:45 1.8
>> +++ ObjectPool.java 2000/10/02 17:24:07 1.9
>> @@ -28,7 +28,7 @@
>> * <LI>Shut it down</LI>
>> * </OL>
>> * @see org.jboss.minerva.pools.PooledObject
>> - * @version $Revision: 1.8 $
>> + * @version $Revision: 1.9 $
>> * @author Aaron Mulder ([EMAIL PROTECTED])
>> */
>> public class ObjectPool implements PoolEventListener {
>> @@ -733,7 +733,7 @@
>> Iterator it = new HashSet(objects.values()).iterator();
>> while(it.hasNext()) {
>> ObjectRecord rec = (ObjectRecord)it.next();
>> - if(!rec.isInUse() && rec.getMillisSinceLastUse() >=
>gcMinIdleMillis) {
>> + if(rec.isInUse() && rec.getMillisSinceLastUse() >=
>gcMinIdleMillis) {
>> releaseObject(rec.getClientObject());
>> }
>> }
>>
>>
>>
>>
