Hello again.  I have a few changes to the proxy and handle classes which
allow saving the initial context environment.  The problem is (which might
not be a problem at all) is that in the process of adding this support I
have condensed the *SessionProxy classes into a single SessionProxy, as well
as javadoc'd most of the methods and fields in GenericProxy, EntityProxy and
SessionProxy (force of habbit... and a little bit of me being anal about
it).

I have also moved some of the common bean proxy code to BeanProxy.  I still
have a little work left to do on the handles to get them to work with
properly... and my question is: will this step on any ones toes?

I can leave the classes the way they are and simply add this feature, but I
think that there is a little too much code duplication currently.  For
example StatefulSessionProxy and StatelessSessionProxy are almost identical;
there are only minor changes.  This is why I merged the two of them into
SessionProxy.  This works with the existing jrmp1x classes, but simply
changing them to extend from SessionProxy.

I think that it would also be possible to condense SessionProxy and
EntityProxy into one class, though that may not really be necessary.  I
think that using the condensed version is a little better as it makes it
easier to maintain, though for the speed purists out there it does add a
little baggage (not much) over the current version.

I also noticed that all of the bean proxies did a static lookup of EJB
methods, which is common to all of them, so I created BeanProxy, which
contains these static fields as well as the code to lookup the EJBHome with
the correct context.

I didn't want to add this to GenericProxy, as HomeProxy doesn't really need
any of these.

If someone could please advise me on what I should do I would appreciate it.
I am more than willing to help out, but I don't want anyone to get offended
in the process.  I also have a habit of trying to fix things... meaning,
that I could simply patch the current classes, but I would rather help clean
them up and make them better overall.

Thanks.

--jason


Reply via email to