Ok sorry I am late on this discussion, I just upgraded my PC and it nuked outlook there for a while, full day of cold sweat down my spine. comments below |True, but since we cannot change Tomcat it was the best/easiest way to |do it. that is correct see previous mail, we don't control the stuff and we have a way to implement integration without requiring API changes. That is a about the only time I believe that implicit has an edge as it doesn't require "API" just correct implementations. |> a) makes the ContainerFactory (maybe afterwards the J2EEDeployer, |> EmbeddedTomcat) code more readable | |Yes. Agree. Yes but beware of "repackage-itis", even Rickard falls prey to it sometimes :) |> b) allows for a reusability of J2EEDeployer, ContainerFactory and |> EmbeddedTomcat also when having |> "non-flat" deployment structures. | |Again, don't follow. What do you mean by this? I am not sure I understand this fully either, but the only thing I do see is the container stack today is very "static" we do say addInterceptor(new something()); where a factory approach to that would be more powerful. we would feed a list of "interceptor XML" and have the factory do addInterceptor(beanConf.nextInterceptorClass().newInstance()); That would be good :) marc
