Hi,
We do have the changelog in CVS, and
if I remember correctly, there is some
tag that can be used for CVS to update
that in the source files automagically.
Also, the author can be automagically
changed to the last CVS committer to
that file. Some of the jbosstest CTS
test source files do this.
But personally, I see no reason to
duplicate information from CVS in the
source files.
Changelogs can be long, so if these
are duplicated in the source, it might
be better to have this at the bottom
of the file.
And for authors, I think it is nice that
the principal authors/architects are
listed in the source, and not being
automagically replaced by the next
person committing a minor change to the
file.
Best Regards,
Ole Husgaard.
marc fleury wrote:
>
> You make a good point,
>
> i believe we need to put all "authors" and then a list of history of changes
> documented in the header... pretty standard from what I understand.
>
> Another "todo" on my task list (ever growing) is "guidelines for commiters"
> and will go something like
> 1- use this template
> 2- put changelog at the beginning
> 3- make sure you check webpages doco
> 4- run compatibility test
> 5- run speed test
> 6- commit
>
> pfff
>
> marc
>
> |-----Original Message-----
> |From: [EMAIL PROTECTED]
> |[mailto:[EMAIL PROTECTED]]On Behalf Of Ole Husgaard
> |Sent: Saturday, February 10, 2001 2:27 PM
> |To: jBoss Developer
> |Subject: Re: [jBoss-Dev] CVS update:
> |jboss/src/main/org/jboss/ejbMethodInvocation.java
> |
> |
> |Hi,
> |
> |marc fleury wrote:
> |> 1- when you modify a class please please please add yourself as author
> |
> |Always, or only in case of major
> |changes?
> |
> |I considered this a minor change
> |(not counting indentation changes and
> |javadoc comments), so I decided against
> |adding myself to the author list.
> |
> |In some projects adding yourself as an
> |author when doing minor changes is
> |considered recless self-promotion, but
> |I have no problems with always adding
> |myself if you say so.
> |
> |Or maybe I have been too modest, and
> |should add myself for changes this
> |size and not for other more minor
> |changes, like the one-liners I did
> |to jbosstest to avoid verifier
> |warnings?
> |
> |
> |> 2- it seems to slow down the whole system dramatically we need
> |to think some
> |> more
> |
> |Currently doing some more testing to
> |see if I can find something that gives
> |this dramatical slowdown.
> |If you know some way other than setting
> |up an embedded Tomcat, please let me
> |know.
> |
> |
> |Best Regards,
> |
> |Ole Husgaard.
> |
