User: starksm
Date: 01/10/05 00:41:05
Modified: catalina/src/main/org/jboss/web/catalina/security Tag:
Branch_2_4 JBossSecurityMgrRealm.java
Log:
Null the principal returned by authenticate when securityMgr.isValid() is
false and log the principal assigned roles on authorization failure
Revision Changes Path
No revision
No revision
1.1.2.1 +7 -3
contrib/catalina/src/main/org/jboss/web/catalina/security/JBossSecurityMgrRealm.java
Index: JBossSecurityMgrRealm.java
===================================================================
RCS file:
/cvsroot/jboss/contrib/catalina/src/main/org/jboss/web/catalina/security/JBossSecurityMgrRealm.java,v
retrieving revision 1.1
retrieving revision 1.1.2.1
diff -u -r1.1 -r1.1.2.1
--- JBossSecurityMgrRealm.java 2001/09/26 03:11:30 1.1
+++ JBossSecurityMgrRealm.java 2001/10/05 07:41:04 1.1.2.1
@@ -53,7 +53,7 @@
@see org.jboss.security.SubjectSecurityManager
@author [EMAIL PROTECTED]
-@version $Revision: 1.1 $
+@version $Revision: 1.1.2.1 $
*/
public class JBossSecurityMgrRealm extends RealmBase implements Realm, Valve
{
@@ -255,6 +255,7 @@
else
{
category.debug("User: "+username+" is NOT authenticated");
+ principal = null;
}
}
catch(NamingException e)
@@ -263,7 +264,7 @@
}
return principal;
}
-
+
/**
* Return the Principal associated with the specified username and
* credentials, if there is one; otherwise return <code>null</code>.
@@ -310,7 +311,9 @@
}
else
{
- category.debug("User: "+principal+" is NOT authorized,
requiredRoles="+requiredRoles);
+ RealmMapping securityMgr = (RealmMapping)
securityCtx.lookup("realmMapping");
+ Set userRoles = securityMgr.getUserRoles(principal);
+ category.debug("User: "+principal+" is NOT authorized,
requiredRoles="+requiredRoles+", userRoles="+userRoles);
}
}
catch(NamingException e)
@@ -345,3 +348,4 @@
return new SimplePrincipal(username);
}
}
+
_______________________________________________
Jboss-development mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/jboss-development
