Dain,
The idea was a good one and the code is better for it. Don't worry about
it. Just be more careful next time. We all make mistakes. Make sure you
run jbosstest before you check stuff like this in. I've just got in the
habit of this myself. Also, I've got to start making a list of things to
test so that we can have good regression tests in jbosstest so introduced
problems like this show up in the nightly build.
Bill
> -----Original Message-----
> From: [EMAIL PROTECTED]
> [mailto:[EMAIL PROTECTED]]On Behalf Of Dain
> Sundstrom
> Sent: Tuesday, August 07, 2001 11:19 AM
> To: [EMAIL PROTECTED]
> Subject: Re: [JBoss-dev] synchronizeEntitiesWithinTransaction, null pk &
> remove
>
>
> Mark,
>
> If you remember, I posted to this list the suggested change to the
> interceptor, and waited a day after YOU said it was OK to make the change.
>
> As a side note, I was attempting to move the actual store logic out of the
> interceptor. I moved the sync entities in tx to application. My
> goal being
> to make the interceptor smaller and easier to understand.
>
> -dain
>
> ----- Original Message -----
> From: "marc fleury" <[EMAIL PROTECTED]>
> To: <[EMAIL PROTECTED]>
> Sent: Tuesday, August 07, 2001 10:05 AM
> Subject: RE: [JBoss-dev] synchronizeEntitiesWithinTransaction, null pk &
> remove
>
>
> > bill,
> >
> > between you and I, this is typically the type of problem I want to avoid
> > with the core container interceptors. I know (pretty sure) I
> didn't miss
> > something as basic as that and obviously it wasn't you. If it
> is me then
> it
> > only makes the following point even more true.
> >
> > I put "you must be this tall to ride the dragon" messages in
> the code but
> it
> > seems to have no effect in fact it seems to attract more people
> wanting to
> > take the challenge. You and I know the nightmare that solid synch is (I
> > almost went crazy with it) so it *enfuriates* me when someone comes and
> > changes it without paying attention. Can you track down the
> change (still
> > compiling painfully in RH) and let me know and will send a "friendly
> > reminder privately". :( It could very well be me because I
> honestly don't
> > remember.
> >
> > thanks for being on top of this, I am just tired of going back
> and back to
> > it. It is a waste of our time.
> >
> > we should do it once and for all and then **lock** the 3 classes code in
> CVS
> > :)
> >
> > marcf
> >
> > |-----Original Message-----
> > |From: [EMAIL PROTECTED]
> > |[mailto:[EMAIL PROTECTED]]On Behalf Of Bill
> > |Burke
> > |Sent: Tuesday, August 07, 2001 10:34 AM
> > |To: [EMAIL PROTECTED]
> > |Subject: RE: [JBoss-dev] synchronizeEntitiesWithinTransaction,
> null pk &
> > |remove
> > |
> > |
> > |
> > |
> > |> -----Original Message-----
> > |> From: [EMAIL PROTECTED]
> > |> [mailto:[EMAIL PROTECTED]]On Behalf Of
> Jason
> > |> Dillon
> > |> Sent: Monday, August 06, 2001 9:19 PM
> > |> To: [EMAIL PROTECTED]
> > |> Subject: [JBoss-dev] synchronizeEntitiesWithinTransaction, null pk &
> > |> remove
> > |>
> > |>
> > |> I am running into a problem with entity bean removal where the
> > |pk is null,
> > |> which causes most everything passed (and including)
> > |> Application.synchronizeEntitiesWithinTransaction() to fail
> (called from
> > |> EntityContainer.remove()).
> > |>
> > |
> > |The person who moved synchronizeEntitiesWithinTransaction forgot to
> perform
> > |that same logic that is
> EntitySynchronizationInterceptor.storeEntity. I
> > |should have caught this when I reviewed the code. Sorry, I'll fix it
> now.
> > |
> > |BTW, pk get's set to null when a remove() is called.
> > |
> > |Bill
> > |
> > |
> > |
> > |_______________________________________________
> > |Jboss-development mailing list
> > |[EMAIL PROTECTED]
> > |http://lists.sourceforge.net/lists/listinfo/jboss-development
> >
> >
> > _______________________________________________
> > Jboss-development mailing list
> > [EMAIL PROTECTED]
> > http://lists.sourceforge.net/lists/listinfo/jboss-development
> >
>
>
> _______________________________________________
> Jboss-development mailing list
> [EMAIL PROTECTED]
> http://lists.sourceforge.net/lists/listinfo/jboss-development
>
_______________________________________________
Jboss-development mailing list
[EMAIL PROTECTED]
http://lists.sourceforge.net/lists/listinfo/jboss-development
