Hi everybody.
I'm just browsing latest CVS sources and see, that build is full of
deprecation warnigns. I'd like to fix that. Some of myy random thoughs
about it:
1. I was once told by Toby Allsopp : "[...] the idea is to keep as up to
date as possible in the main CVS branch." :-)
2. Main sources of deprecation warnings:
- warnings that can't be removed, due to deprecations
existence in Sun's specs:
server/src/main/org/jboss/ejb/EnterpriseContext.java
j2ee/src/main/javax/ejb/EJBContext.java
- warnings that we can easily remove:
server/src/main/org/jboss/util/Executor.java
server/src/main/org/jboss/util/FileURLPatch.java
server/src/main/org/jboss/jmx/server/XMLTestService.java
connector/src/main/org/jboss/resource/security/PrincipalMapping
Some old code, easy to upgrade - see attached patch (misc.diff.gz).
- warnings that I think we must think about before removal:
messaging/src/main/org/jboss/mq/xml/XElement.java
messaging/src/main/org/jboss/mq/xml/XElementProducer.java
These two seem easy to improve - because we package JAXP parser
(Crimson) that supports SAX 2.0, let's just switch
"AttributeList -> Attributes" and "getName() -> getLocalName()".
Looking the way this code is used (ClusterTopicConnectionFactory) I
assume it's local name that gets stored in XElement. Hiram Chirino
(or someone maintaining messaging module) please apply patch below
(mq.diff.gz)
connector/src/main/org/jboss/resource/adapter/jdbc/local/ResultSetInPool.java
connector/src/main/org/jboss/resource/adapter/jdbc/local/PreparedStatementInPool.java
These two generate deprecation warnings, because they use deprecated
methods of JDBC spec (namely [get|set]UnicodeStream and
getBigDecimal). Resolving this would require all drivers to support
JDBC 2.1 (am I wrong ?). I'm not quite sure wether this is
reasonable. Can someone give me a hint about this ? I'll investigate
more before correcting (if ever) and submitting patch...
- logging deprecation warnigns:
Waiting for Jason & Dillon's loggin policy/new Logger implementation
- Javadoc warnigns - too many to mention.
Will wait forever :-)
Any comments ? Questions ?
Scooter
P.S. Stuff compiles, server runs without warnign, but I can't assure it
didn't introduce some subltle bug :-)
misc.diff.gz
mq.diff.gz
