Hi,

A plea from me to all CVS committers:

Before you commit, please run the test suite.

It seems to cover the code base fine, and bugs introduced
are almost always caught here.

When you see that some test fails because of a change you
made, you can relatively quickly fix it because you know
where in the code to look.
But if you do not run it, and just commit your changes
someone else may have to fix the bug you introduced, and
that can be slow, because the other person does not know
where in the code to look.

For example, tonight I decided to spend an evening
hacking JBoss. But about half of the tests in the test
suite failed, so I had to fix that first.
So instead of doing useful work on JBoss, i spent my
evening looking all over the code for a bug somebody
else introduced.
Finally I found the bug: It was a simple typo that made
half the test suite fail, and that the committer could
have fixed in two minutes if he had run the test suite
before committing.

It doesn't matter who didn't run the test suite this
time, and it is not the first time I spend the first
few hours hunting down someone elses bug before I
can start real work on JBoss.
For the last month or so, I have wasted hours because
of this each time I wanted to spend some time
developing JBoss.

One reason I use the test suite is that I do not want
to introduce new bugs into JBoss. So I always run it
before and after my changes and compare to ensure that
no more test failures occur due to my changes.
But when _lots_ of test fail, I have do fix that before
the test suite is useful.

Of course I feel tempted to _not_ use the test suite
at all because of this. But if everybody thinks that
way, we would probably _never_ get rabbithole past
alpha level.


Please run the testsuite before committing!


Best Regards,

Ole Husgaard.

_______________________________________________
Jboss-development mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/jboss-development

Reply via email to