Hi
I think to add everywhere a DomainName to the ObjectNames of the MBeans
is a great idea. But please keep in mind that some MBean overwrite the given
ObjectName to enforce a particulare name (see preRegister()) methods.
On the other side not all MBeans should be added to JBOSS-SYSTEM because
the domain name is used to segment the JMX namespace. JBOSS-SYSTEM is
the default domain name meaning that a client does not have to know the
default
domain name to search for these MBeans. But when you want to create a
special
segement where it is necessary for a client to know the name and a grouping
is
appropriate then I think it is better to use a separate Domain Name.
Have fun - Andy
----- Original Message -----
From: "Guillaume Boissiere" <[EMAIL PROTECTED]>
To: "Andreas Schaefer" <[EMAIL PROTECTED]>;
<[EMAIL PROTECTED]>
Sent: Friday, November 02, 2001 8:31 PM
Subject: RE: [JBoss-dev] OBJECT_NAME rules
> Andy,
>
> Thanks for your quick response! Here is an updated patch that makes
> the naming more in line with the spec, by adding JBOSS-SYSTEM where
> it is missing in the code.
> Should make it easier to use the full Object Name capabilities in
> the future.
> Comments welcome,
>
> -- Guillaume
>
>
> diff -urN
> jboss/src/main/org/jboss/configuration/ConfigurationServiceMBean.java
> gb-jboss/src/main/org/jboss/configuration/ConfigurationServiceMBean.java
> --- jboss/src/main/org/jboss/configuration/ConfigurationServiceMBean.java
> Fri Aug 3 13:15:42 2001
> +++
gb-jboss/src/main/org/jboss/configuration/ConfigurationServiceMBean.java
> Fri Nov 2 23:03:50 2001
> @@ -19,7 +19,7 @@
> public interface ConfigurationServiceMBean
> {
> /** The default object name. */
> - public static final String OBJECT_NAME = ":service=Configuration";
> + public static final String OBJECT_NAME =
> "JBOSS-SYSTEM:service=Configuration";
>
> /**
> * Get the attribute value auto-trim flag.
> diff -urN jboss/src/main/org/jboss/deployment/AutoDeployerMBean.java
> gb-jboss/src/main/org/jboss/deployment/AutoDeployerMBean.java
> --- jboss/src/main/org/jboss/deployment/AutoDeployerMBean.java Wed Aug 29
> 18:52:05 2001
> +++ gb-jboss/src/main/org/jboss/deployment/AutoDeployerMBean.java Fri Nov
2
> 21:39:32 2001
> @@ -22,7 +22,7 @@
> extends ServiceMBean
> {
> /** The default object name. */
> - String OBJECT_NAME = "EJB:service=AutoDeployer";
> + public static final String OBJECT_NAME = "EJB:service=AutoDeployer";
>
> /**
> * Set the list of urls to watch.
> diff -urN jboss/src/main/org/jboss/deployment/J2eeDeployer.java
> gb-jboss/src/main/org/jboss/deployment/J2eeDeployer.java
> --- jboss/src/main/org/jboss/deployment/J2eeDeployer.java Mon Oct 8
> 03:03:49 2001
> +++ gb-jboss/src/main/org/jboss/deployment/J2eeDeployer.java Fri Nov 2
> 23:06:23 2001
> @@ -81,11 +81,11 @@
> // Constants -----------------------------------------------------
> public File DEPLOYMENT_DIR = null;//"/home/deployment"; // default?
> MUST BE ABSOLUTE PATH!!!
> public static String CONFIG = "deployment.cfg";
> - final public static String DEFAULT_NAME="Default";
> - final public static String
> DEFAULT_JAR_DEPLOYER_NAME="EJB:service=ContainerFactory";
> - final public static String
> DEFAULT_WAR_DEPLOYER_NAME=":service=EmbeddedTomcat";
> - final public static String
> DEFAULT_RAR_DEPLOYER_NAME=":service=RarDeployer";
> - final public static String
> DEFAULT_JAVA_DEPLOYER_NAME=":service=JavaDeployer";
> + public static final String DEFAULT_NAME="Default";
> + public static final String
> DEFAULT_JAR_DEPLOYER_NAME="EJB:service=ContainerFactory";
> + public static final String
> DEFAULT_WAR_DEPLOYER_NAME="EJB:service=EmbeddedTomcat";
> + public static final String
> DEFAULT_RAR_DEPLOYER_NAME="EJB:service=RarDeployer";
> + public static final String
> DEFAULT_JAVA_DEPLOYER_NAME="EJB:service=JavaDeployer";
>
> public static final int EASY = 0;
> public static final int RESTRICTIVE = 1;
> diff -urN jboss/src/main/org/jboss/ejb/ContainerFactoryMBean.java
> gb-jboss/src/main/org/jboss/ejb/ContainerFactoryMBean.java
> --- jboss/src/main/org/jboss/ejb/ContainerFactoryMBean.java Wed Aug 29
> 23:10:02 2001
> +++ gb-jboss/src/main/org/jboss/ejb/ContainerFactoryMBean.java Fri Nov 2
> 23:07:46 2001
> @@ -25,7 +25,7 @@
> extends ServiceMBean
> {
> /** The default object name. */
> - String OBJECT_NAME = ":service=ContainerFactory";
> + public static final String OBJECT_NAME =
> "JBOSS-SYSTEM:service=ContainerFactory";
>
> /**
> * Returns the applications deployed by the container factory
> diff -urN jboss/src/main/org/jboss/ejb/ContainerRelection.java
> gb-jboss/src/main/org/jboss/ejb/ContainerRelection.java
> --- jboss/src/main/org/jboss/ejb/ContainerRelection.java Fri Nov 2
15:41:40
> 2001
> +++ gb-jboss/src/main/org/jboss/ejb/ContainerRelection.java Fri Nov 2
> 23:09:09 2001
> @@ -23,7 +23,7 @@
> */
> public class ContainerRelection extends ServiceMBeanSupport implements
> ContainerRelectionMBean
> {
> - /** Lookup the mbean located under the object name
> ":service=Container,jndiName=<jndiName>"
> + /** Lookup the mbean located under the object name
> "JBOSS-SYSTEM:service=Container,jndiName=<jndiName>"
> and invoke the getHome and getRemote interfaces and dump the methods
> for each
> in an html pre block.
> */
> @@ -34,7 +34,7 @@
> try
> {
> buffer.append("<pre>");
> - ObjectName containerName = new
> ObjectName(":service=Container,jndiName="+jndiName);
> + ObjectName containerName = new
> ObjectName("JBOSS-SYSTEM:service=Container,jndiName="+jndiName);
> Class homeClass = (Class) server.invoke(containerName,
"getHome",
> null, null);
> buffer.append("\nHome class = "+homeClass);
> buffer.append("\nClassLoader: "+homeClass.getClassLoader());
> diff -urN jboss/src/main/org/jboss/ejb/ContainerRelectionMBean.java
> gb-jboss/src/main/org/jboss/ejb/ContainerRelectionMBean.java
> --- jboss/src/main/org/jboss/ejb/ContainerRelectionMBean.java Mon Aug 13
> 23:31:34 2001
> +++ gb-jboss/src/main/org/jboss/ejb/ContainerRelectionMBean.java Fri Nov
2
> 23:09:39 2001
> @@ -9,7 +9,7 @@
> */
> public interface ContainerRelectionMBean
> {
> - /** Lookup the mbean located under the object name
> ":service=Container,jndiName=<jndiName>"
> + /** Lookup the mbean located under the object name
> "JBOSS-SYSTEM:service=Container,jndiName=<jndiName>"
> and invoke the getHome and getRemote interfaces and dump the methods
> for each
> in an html pre block.
> */
> diff -urN
jboss/src/main/org/jboss/jms/asf/ServerSessionPoolLoaderMBean.java
> gb-jboss/src/main/org/jboss/jms/asf/ServerSessionPoolLoaderMBean.java
> --- jboss/src/main/org/jboss/jms/asf/ServerSessionPoolLoaderMBean.java Wed
> Aug 29 23:10:54 2001
> +++ gb-jboss/src/main/org/jboss/jms/asf/ServerSessionPoolLoaderMBean.java
> Fri Nov 2 23:10:17 2001
> @@ -31,7 +31,7 @@
> extends ServiceMBean
> {
> /** The default MBean object name. */
> - String OBJECT_NAME = ":service=ServerSessionPoolMBean";
> + public static final String OBJECT_NAME =
> "JBOSS-SYSTEM:service=ServerSessionPoolLoader";
>
> /**
> * Set the pool name.
> diff -urN jboss/src/main/org/jboss/jms/jndi/JMSProviderLoaderMBean.java
> gb-jboss/src/main/org/jboss/jms/jndi/JMSProviderLoaderMBean.java
> --- jboss/src/main/org/jboss/jms/jndi/JMSProviderLoaderMBean.java Wed Aug
29
> 23:10:54 2001
> +++ gb-jboss/src/main/org/jboss/jms/jndi/JMSProviderLoaderMBean.java Fri
Nov
> 2 23:11:00 2001
> @@ -34,7 +34,7 @@
> public interface JMSProviderLoaderMBean
> extends ServiceMBean
> {
> - public static final String OBJECT_NAME = ":service=JMSProviderLoader";
> + public static final String OBJECT_NAME =
> "JBOSS-SYSTEM:service=JMSProviderLoader";
>
> public void setProviderName(String name);
>
> diff -urN jboss/src/main/org/jboss/jmx/adaptor/xml/XMLTestService.java
> gb-jboss/src/main/org/jboss/jmx/adaptor/xml/XMLTestService.java
> --- jboss/src/main/org/jboss/jmx/adaptor/xml/XMLTestService.java Tue Oct
23
> 23:10:52 2001
> +++ gb-jboss/src/main/org/jboss/jmx/adaptor/xml/XMLTestService.java Fri
Nov
> 2 23:13:19 2001
> @@ -76,9 +76,9 @@
> Document lTest =
> DocumentBuilderFactory.newInstance().newDocumentBuilder().parse(
> new ByteArrayInputStream(new String(
> "<jmx>" +
> - "<invoke operation=\"stop\"><object-name
> name=\":service=Scheduler\"/></invoke>" +
> + "<invoke operation=\"stop\"><object-name
> name=\"JBOSS-SYSTEM:service=Scheduler\"/></invoke>" +
> "<create-mbean code=\"org.jboss.util.Scheduler\">" +
> - "<object-name name=\":service=Scheduler\"/>" +
> + "<object-name name=\"JBOSS-SYSTEM:service=Scheduler\"/>" +
> "<constructor>" +
> "<argument
> type=\"java.lang.String\">:server=Scheduler</argument>" +
> "<argument
>
type=\"java.lang.String\">org.jboss.util.Scheduler$SchedulableExample</argum
> ent>" +
> @@ -90,7 +90,7 @@
> "</constructor>" +
> "</create-mbean>" +
> "<set-attribute>" +
> - "<object-name name=\":service=Scheduler\"/>" +
> + "<object-name name=\"JBOSS-SYSTEM:service=Scheduler\"/>" +
> "<attribute name=\"PeriodTime\">5000</attribute>" +
> "</set-attribute>" +
> "</jmx>"
> diff -urN jboss/src/main/org/jboss/logging/Log4jServiceMBean.java
> gb-jboss/src/main/org/jboss/logging/Log4jServiceMBean.java
> --- jboss/src/main/org/jboss/logging/Log4jServiceMBean.java Fri Aug 3
> 13:15:53 2001
> +++ gb-jboss/src/main/org/jboss/logging/Log4jServiceMBean.java Fri Nov 2
> 23:14:07 2001
> @@ -15,7 +15,7 @@
> public interface Log4jServiceMBean
> {
> /** The default name of the service */
> - public static final String OBJECT_NAME =
":service=Logging,type=Log4J";
> + public static final String OBJECT_NAME =
> "JBOSS-SYSTEM:service=Logging,type=Log4J";
>
> /** Get the log4j.properties format config file path
> */
> diff -urN jboss/src/main/org/jboss/mail/MailServiceMBean.java
> gb-jboss/src/main/org/jboss/mail/MailServiceMBean.java
> --- jboss/src/main/org/jboss/mail/MailServiceMBean.java Wed Aug 29
23:58:12
> 2001
> +++ gb-jboss/src/main/org/jboss/mail/MailServiceMBean.java Fri Nov 2
> 23:14:25 2001
> @@ -18,7 +18,7 @@
> extends org.jboss.system.ServiceMBean
> {
> // Constants -----------------------------------------------------
> - public static final String OBJECT_NAME = ":service=Mail";
> + public static final String OBJECT_NAME = "JBOSS-SYSTEM:service=Mail";
>
> // Public --------------------------------------------------------
> /**
> diff -urN jboss/src/main/org/jboss/naming/JNDIViewMBean.java
> gb-jboss/src/main/org/jboss/naming/JNDIViewMBean.java
> --- jboss/src/main/org/jboss/naming/JNDIViewMBean.java Wed Aug 29 23:31:21
> 2001
> +++ gb-jboss/src/main/org/jboss/naming/JNDIViewMBean.java Fri Nov 2
> 23:15:05 2001
> @@ -18,7 +18,7 @@
> public interface JNDIViewMBean extends org.jboss.system.ServiceMBean
> {
> // Constants -----------------------------------------------------
> - public static final String OBJECT_NAME = ":service=JNDIView";
> + public static final String OBJECT_NAME =
> "JBOSS-SYSTEM:service=JNDIView";
>
> // Public --------------------------------------------------------
>
> diff -urN jboss/src/main/org/jboss/naming/NamingServiceMBean.java
> gb-jboss/src/main/org/jboss/naming/NamingServiceMBean.java
> --- jboss/src/main/org/jboss/naming/NamingServiceMBean.java Wed Aug 29
> 23:31:21 2001
> +++ gb-jboss/src/main/org/jboss/naming/NamingServiceMBean.java Fri Nov 2
> 23:16:01 2001
> @@ -17,7 +17,7 @@
> extends org.jboss.system.ServiceMBean, org.jnp.server.MainMBean
> {
> // Constants -----------------------------------------------------
> - public static final String OBJECT_NAME = ":service=Naming";
> + public static final String OBJECT_NAME =
"JBOSS-SYSTEM:service=Naming";
>
> // Public --------------------------------------------------------
> }
> diff -urN jboss/src/main/org/jboss/system/FarmAutoDeployerMBean.java
> gb-jboss/src/main/org/jboss/system/FarmAutoDeployerMBean.java
> --- jboss/src/main/org/jboss/system/FarmAutoDeployerMBean.java Sat Oct 20
> 00:24:23 2001
> +++ gb-jboss/src/main/org/jboss/system/FarmAutoDeployerMBean.java Fri Nov
2
> 21:47:42 2001
> @@ -22,7 +22,7 @@
> extends ServiceMBean
> {
> /** The default object name. */
> - String OBJECT_NAME = "EJB:service=AutoDeployer";
> + public static final String OBJECT_NAME = "EJB:service=AutoDeployer";
>
> /**
> * Set the list of urls to watch.
> diff -urN jboss/src/main/org/jboss/system/InfoMBean.java
> gb-jboss/src/main/org/jboss/system/InfoMBean.java
> --- jboss/src/main/org/jboss/system/InfoMBean.java Fri Sep 7 20:53:56
2001
> +++ gb-jboss/src/main/org/jboss/system/InfoMBean.java Fri Nov 2 21:49:25
> 2001
> @@ -17,7 +17,7 @@
> */
> public interface InfoMBean
> {
> - String OBJECT_NAME = "JBOSS-SYSTEM:service=Info";
> + public static final String OBJECT_NAME = "JBOSS-SYSTEM:service=Info";
>
> String listMemoryUsage();
> String listSystemInfo();
> diff -urN jboss/src/main/org/jboss/system/ServiceLibrariesMBean.java
> gb-jboss/src/main/org/jboss/system/ServiceLibrariesMBean.java
> --- jboss/src/main/org/jboss/system/ServiceLibrariesMBean.java Fri Sep 7
> 20:53:57 2001
> +++ gb-jboss/src/main/org/jboss/system/ServiceLibrariesMBean.java Fri Nov
2
> 21:49:26 2001
> @@ -22,7 +22,7 @@
> */
> public interface ServiceLibrariesMBean
> {
> - String OBJECT_NAME = "JBOSS-SYSTEM:service=Libraries";
> + public static final String OBJECT_NAME =
> "JBOSS-SYSTEM:service=Libraries";
>
> // The ServicesLibraries MBean should expose "soft" information like
> // the dependencies graph
> diff -urN jboss/src/main/org/jboss/tm/TransactionManagerServiceMBean.java
> gb-jboss/src/main/org/jboss/tm/TransactionManagerServiceMBean.java
> --- jboss/src/main/org/jboss/tm/TransactionManagerServiceMBean.java Wed
Aug
> 29 23:39:18 2001
> +++ gb-jboss/src/main/org/jboss/tm/TransactionManagerServiceMBean.java Fri
> Nov 2 23:16:51 2001
> @@ -19,7 +19,7 @@
> extends org.jboss.system.ServiceMBean
> {
> // Constants -----------------------------------------------------
> - public static final String OBJECT_NAME =
":service=TransactionManager";
> + public static final String OBJECT_NAME =
> "JBOSS-SYSTEM:service=TransactionManager";
>
> // Public --------------------------------------------------------
> public int getTransactionTimeout();
> diff -urN
>
jboss/src/main/org/jboss/tm/usertx/server/ClientUserTransactionServiceMBean.
> java
>
gb-jboss/src/main/org/jboss/tm/usertx/server/ClientUserTransactionServiceMBe
> an.java
> ---
>
jboss/src/main/org/jboss/tm/usertx/server/ClientUserTransactionServiceMBean.
> java Wed Aug 29 23:39:18 2001
> +++
>
gb-jboss/src/main/org/jboss/tm/usertx/server/ClientUserTransactionServiceMBe
> an.java Fri Nov 2 23:17:30 2001
> @@ -16,6 +16,6 @@
> public interface ClientUserTransactionServiceMBean
> extends org.jboss.system.ServiceMBean
> {
> - public static final String OBJECT_NAME =
> ":service=ClientUserTransaction";
> + public static final String OBJECT_NAME =
> "JBOSS-SYSTEM:service=ClientUserTransaction";
> }
>
> diff -urN jboss/src/main/org/jboss/util/Executor.java
> gb-jboss/src/main/org/jboss/util/Executor.java
> --- jboss/src/main/org/jboss/util/Executor.java Fri Sep 28 18:33:56 2001
> +++ gb-jboss/src/main/org/jboss/util/Executor.java Fri Nov 2 23:18:02
2001
> @@ -25,7 +25,7 @@
> implements ExecutorMBean, MBeanRegistration
> {
> // Constants -----------------------------------------------------
> - public static final String OBJECT_NAME = ":service=Executor";
> + public static final String OBJECT_NAME =
> "JBOSS-SYSTEM:service=Executor";
> private static Logger log = Logger.create("Executor");
>
> // Attributes ----------------------------------------------------
> diff -urN jboss/src/main/org/jboss/util/FileURLPatch.java
> gb-jboss/src/main/org/jboss/util/FileURLPatch.java
> --- jboss/src/main/org/jboss/util/FileURLPatch.java Fri Sep 28 18:33:56
2001
> +++ gb-jboss/src/main/org/jboss/util/FileURLPatch.java Fri Nov 2 23:18:24
> 2001
> @@ -28,7 +28,7 @@
> */
> public class FileURLPatch implements FileURLPatchMBean, MBeanRegistration
{
>
> - public static final String OBJECT_NAME= ":service=FileURLPatch";
> + public static final String OBJECT_NAME=
> "JBOSS-SYSTEM:service=FileURLPatch";
> Category log= Category.getInstance(FileURLPatch.class);
> private CustomURLStreamHandlerFactory customURLStreamHandlerFactory=
new
> CustomURLStreamHandlerFactory();
> private boolean enabled= false;
> diff -urN jboss/src/main/org/jboss/util/Info.java
> gb-jboss/src/main/org/jboss/util/Info.java
> --- jboss/src/main/org/jboss/util/Info.java Fri Aug 3 13:15:57 2001
> +++ gb-jboss/src/main/org/jboss/util/Info.java Fri Nov 2 23:18:42 2001
> @@ -28,7 +28,7 @@
> {
> // Constants -----------------------------------------------------
>
> - public static final String OBJECT_NAME= ":service=Info";
> + public static final String OBJECT_NAME= "JBOSS-SYSTEM:service=Info";
>
> // Attributes ----------------------------------------------------
>
> diff -urN jboss/src/main/org/jboss/web/WebServiceMBean.java
> gb-jboss/src/main/org/jboss/web/WebServiceMBean.java
> --- jboss/src/main/org/jboss/web/WebServiceMBean.java Thu Aug 30 00:13:42
> 2001
> +++ gb-jboss/src/main/org/jboss/web/WebServiceMBean.java Fri Nov 2
23:19:07
> 2001
> @@ -19,7 +19,7 @@
> extends org.jboss.system.ServiceMBean
> {
> // Constants -----------------------------------------------------
> - public static final String OBJECT_NAME = ":service=Webserver";
> + public static final String OBJECT_NAME =
> "JBOSS-SYSTEM:service=Webserver";
>
> // Public --------------------------------------------------------
> public URL addClassLoader(ClassLoader cl);
>
>
>
> > -----Original Message-----
> > From: Andreas Schaefer [mailto:[EMAIL PROTECTED]]
> > Sent: Friday, November 02, 2001 10:36 PM
> > To: Guillaume Boissiere; [EMAIL PROTECTED]
> > Subject: Re: [JBoss-dev] OBJECT_NAME rules
> >
> >
> > Hi
> >
> > Your are right but Object Names rules are:
> > <Domain Name>:[<key>=<value>],...
> >
> > Right now JBoss does not use the Object Name capabilities fully
> > one part you can see this is in the J2eeDeployer and WebDeployer.
> > There we could create the WebDeployer service like this:
> > JBOSS-SYSTEM:service=deployer,type=web,vendor=jetty
> >
> > This would enable use to skip to specify the WebDeployer name
> > in the J2eeDeployer but instead the J2eeDeployer could search
> > for a service with:
> > JBOSS-SYSTEM:service=deployer,typ=web
> > and whatever vendor the web deployer service provides does
> > not matter.
> >
> > The Object names with no Domain Name is the worst because in
> > JMX-RI is a big bug not able to find this MBean even it does allow
> > the MBean to be registered with its name.
> >
> > Have fun - Andy
>
>
_______________________________________________
Jboss-development mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/jboss-development
