In general the logging in Main is way overboard as not everyone is upto speed with the trace level logging support. This is the first thing I will address when I get back to working on Main next week.
xxxxxxxxxxxxxxxxxxxxxxxx Scott Stark Chief Technology Officer JBoss Group, LLC xxxxxxxxxxxxxxxxxxxxxxxx ----- Original Message ----- From: "David Maplesden" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Wednesday, November 14, 2001 12:52 PM Subject: RE: [JBoss-dev] CVS update: jbossmq/src/main/org/jboss/mq/pm/file CacheStore.java CacheStoreMBean.java > Thanks, that's good to know. The amount and level of logging in JBossMQ > needs to be looked at, its not completely hopeless, but its far from > consistent (mainly because of my changes I guess). > > > -----Original Message----- > > From: Scott M Stark [mailto:[EMAIL PROTECTED]] > > Sent: Thursday, November 15, 2001 9:46 AM > > To: [EMAIL PROTECTED] > > Subject: Re: [JBoss-dev] CVS update: > > jbossmq/src/main/org/jboss/mq/pm/file CacheStore.java > > CacheStoreMBean.java > > > > > > This is the purpose of the Logger.isXXXEnabled() call. Any debugging > > that is executed on a per message basis should be a trace > > level message > > that is enclosed inside of a test for that priority level > > being active. This > > allows for enabling tracing with very fine control at runtime > > and one of > > the primary reasons for basing logging on log4j. This incurs a minimal > > overhead. The current Logger class is a subclass of the log4j Category > > and this will be changed next week, but that will not change the usage > > pattern which is as follows: > > > > import org.jboss.logging.Logger; > > > > public abstract class SomeClass > > { > > protected Logger log = Logger.create(Some.class or > > whatever category > > name); > > > > protected void register(EntityEnterpriseContext ctx, > > Transaction tx) > > { > > boolean trace = log.isTraceEnabled(); > > if( trace ) > > log.trace("register, ctx="+ctx+", tx="+tx); > > } > > } > > _______________________________________________ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
