A debug level message should not require an explicit conditional check as it should not be called frequently. If it is, then it should be a trace level message with a check.
xxxxxxxxxxxxxxxxxxxxxxxx Scott Stark Chief Technology Officer JBoss Group, LLC xxxxxxxxxxxxxxxxxxxxxxxx ----- Original Message ----- From: "marc fleury" <[EMAIL PROTECTED]> To: "Jboss-Development@Lists. Sourceforge. Net" <[EMAIL PROTECTED]> Sent: Tuesday, December 18, 2001 3:20 PM Subject: [JBoss-dev] use of if(debug) log.debug > ??? > > I have a conflict on ServiceDeployer.java > > the conflict is due to the inclusion of "if (debug) log.debug(...)" > > with debug being log.isDebugEnabled()... > > do we need to explicitely do that? I thought part of the interest is that > the log4j thing would not do anything with the messages if debug was not > enabled so why the explicit test? > > I will remove these unless something clearly says the contrary > > marcf > > xxxxxxxxxxxxxxxx > Marc Fleury > President > JBoss Group, LLC > xxxxxxxxxxxxxxxx > > > _______________________________________________ > Jboss-development mailing list > [EMAIL PROTECTED] > https://lists.sourceforge.net/lists/listinfo/jboss-development > _______________________________________________ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
