User: squirest
Date: 01/12/21 12:56:39
Modified: src/main/javax/management ObjectName.java
Log:
bugfix in illegal character detection
Revision Changes Path
1.4 +22 -3 jmx/src/main/javax/management/ObjectName.java
Index: ObjectName.java
===================================================================
RCS file: /cvsroot/jboss/jmx/src/main/javax/management/ObjectName.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- ObjectName.java 2001/12/21 03:01:45 1.3
+++ ObjectName.java 2001/12/21 20:56:38 1.4
@@ -19,7 +19,7 @@
*
* @author <a href="mailto:[EMAIL PROTECTED]";>Juha Lindfors</a>.
* @author <a href="mailto:[EMAIL PROTECTED]";>Trevor Squires</a>.
- * @version $Revision: 1.3 $
+ * @version $Revision: 1.4 $
*
*/
public class ObjectName implements java.io.Serializable
@@ -156,7 +156,7 @@
throw new MalformedObjectNameException("null domain");
}
- if (dstring.indexOf(',') > -1 || dstring.indexOf('=') > -1)
+ if (isIllegalDomain(dstring))
{
throw new MalformedObjectNameException("domain contains illegal
characters");
}
@@ -339,6 +339,25 @@
return false;
}
-}
+ /**
+ * returns true if the key or value string is zero length or contains illegal
characters
+ */
+ private boolean isIllegalDomain(String dom)
+ {
+ char[] chars = dom.toCharArray();
+ for (int i = 0; i < chars.length; i++)
+ {
+ switch (chars[i])
+ {
+ case ':':
+ case ',':
+ case '=':
+ return true;
+ }
+ }
+
+ return false;
+ }
+}
_______________________________________________
Jboss-development mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/jboss-development
