I will take a look at this too.  I like the flat predeploy, actually I was
aiming for it in my recursive unpack...

david jencks

On 2002.02.07 15:24:13 -0500 marc fleury wrote:
> Nachrichtjung
> 
> 1- Ok i agree that we should make the list of deployable checks dynamic.
> Each deployer register with the MainDeployer and the registration sends a
> callback that gets the "extension" you support.  Note that the "find
> deployer" is a bit more advanced than the extension only (for example the
> EJBDeployer takes jars w/ xml files you need both) so don't go changing
> that.  But yes this is a very valid idea.  Go right ahead if you fancy it
> and like the Deployers, if not David can you pick it up? at ANY rate
> please
> submit a feature request... so we can track it.
> 
> 2- I am thinking about your "flat predeploy" get all the classes loaded
> on
> this pass and then init/start and I think it is actually a good idea, I
> need
> to think a bit about it though.
> 
> 3- PLEASE PLEASE PLEASE use cvs patch tracking.  ALL the discussions take
> place there and you will be amazed when you read some of the bugs and
> patches there and their quality.
> 
> I know you are overwhelmed in your day-job....
> 
> marcf
>   -----Original Message-----
>   From: [EMAIL PROTECTED]
> [mailto:[EMAIL PROTECTED]]On Behalf Of Jung ,
> Dr. Christoph
>   Sent: Thursday, February 07, 2002 9:06 AM
>   To: 'Jboss-Development ([EMAIL PROTECTED])'
>   Subject: AW: [JBoss-dev] Web-Inf Deployment and MainDeployer
> 
> 
>   Hi,
>     -----Urspr�ngliche Nachricht-----
>     Von: marc fleury [mailto:[EMAIL PROTECTED]]
>     Gesendet: Donnerstag, 7. Februar 2002 20:55
>     An: Jung , Dr. Christoph; [EMAIL PROTECTED]
>     Betreff: RE: [JBoss-dev] Web-Inf Deployment and MainDeployer
> 
> 
> 
>     I don't understand this patch but I will do it, its ok
> 
>     instead of complaining about non-jar urls (directory) in the
> DeploymentInfo.localUrl, the WebContainer will simply take them as they
> are
> (not trying to extract web-inf classes).
> 
>       The second patch splits the current
> MainDeployer.deploy(DeploymentInfo) method into two phases. A first phase
> that just creates classloaders and registers the deployment and a second
> phase that performs the actual deploy at the target deployers. This
> ensures
> that, e.g., if you have an ear consisting of an ejb-jar and a
> 
>       Deploy is ALREADY split into two phases init and deploy.  It was
> done
> for the ear.  Can you make sure you can't fit your stuff in Init/start as
> opposed to going to a 3 phase creation?
> 
>       Oh, I did not touch the actual Deployer�s structure. It�s just the
> Maindeployer.deploySubPackages that needs a split while treating the
> subdeployments ... Classloader creation must happen already in the first
> loop that collects the jarentries and sets up DeploymentInfos such that
> all
> classes are already available for the upcoming init/deploy calls of the
> actual Deployers, no matter in what order.
> 
>       I have attached the full files this time, because diffs are
> difficult
> to read (and my comments even more, I know).
> 
>       CGJ
> 
> 
> 
> 
> <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
> <HTML><HEAD><TITLE>Nachricht</TITLE>
> <META http-equiv=Content-Type content="text/html; charset=ISO-8859-1">
> <META content="MSHTML 5.50.4134.600" name=GENERATOR></HEAD>
> <BODY>
> <DIV><SPAN class=613501920-07022002><FONT face=Arial color=#0000ff 
> size=2>jung</FONT></SPAN></DIV>
> <DIV><SPAN class=613501920-07022002><FONT face=Arial color=#0000ff 
> size=2></FONT></SPAN>&nbsp;</DIV>
> <DIV><SPAN class=613501920-07022002><FONT face=Arial color=#0000ff
> size=2>1- Ok 
> i agree that we should make the list of deployable checks dynamic. Each
> deployer 
> register with the MainDeployer and the registration sends a callback that
> gets 
> the "extension" you support.&nbsp; Note that the "find deployer" is a bit
> more 
> advanced than the extension only (for example the EJBDeployer takes jars
> w/ xml 
> files you need both) so don't go changing that.&nbsp; But yes this is a
> very 
> valid idea.&nbsp; Go right ahead if you fancy it and like the Deployers,
> if not 
> David can you pick it up? at ANY rate please submit a feature request...
> so we 
> can track it.</FONT></SPAN></DIV>
> <DIV><SPAN class=613501920-07022002><FONT face=Arial color=#0000ff 
> size=2></FONT></SPAN>&nbsp;</DIV>
> <DIV><SPAN class=613501920-07022002><FONT face=Arial color=#0000ff
> size=2>2- I 
> am thinking about your "flat predeploy" get all the classes loaded on
> this pass 
> and then init/start and I think it is actually a good idea, I need to
> think a 
> bit about it though.</FONT></SPAN></DIV>
> <DIV><SPAN class=613501920-07022002><FONT face=Arial color=#0000ff 
> size=2></FONT></SPAN>&nbsp;</DIV>
> <DIV><SPAN class=613501920-07022002><FONT face=Arial color=#0000ff
> size=2>3- 
> PLEASE PLEASE PLEASE use cvs patch tracking.&nbsp; ALL the discussions
> take 
> place there and you will be amazed when you read some of the bugs and
> patches 
> there and their quality.</FONT></SPAN></DIV>
> <DIV><SPAN class=613501920-07022002><FONT face=Arial color=#0000ff 
> size=2></FONT></SPAN>&nbsp;</DIV>
> <DIV><SPAN class=613501920-07022002><FONT face=Arial color=#0000ff
> size=2>I know 
> you are overwhelmed in your day-job....</FONT></SPAN></DIV>
> <DIV><SPAN class=613501920-07022002><FONT face=Arial color=#0000ff 
> size=2></FONT></SPAN>&nbsp;</DIV>
> <DIV><SPAN class=613501920-07022002><FONT face=Arial color=#0000ff 
> size=2>marcf</FONT></SPAN></DIV>
> <BLOCKQUOTE dir=ltr 
> style="PADDING-LEFT: 5px; MARGIN-LEFT: 5px; BORDER-LEFT: #0000ff 2px
> solid; MARGIN-RIGHT: 0px">
>   <DIV class=OutlookMessageHeader dir=ltr align=left><FONT face=Tahoma 
>   size=2>-----Original Message-----<BR><B>From:</B> 
>   [EMAIL PROTECTED] 
>   [mailto:[EMAIL PROTECTED]]<B>On Behalf Of
> </B>Jung 
>   , Dr. Christoph<BR><B>Sent:</B> Thursday, February 07, 2002 9:06 
>   AM<BR><B>To:</B> 'Jboss-Development 
>   ([EMAIL PROTECTED])'<BR><B>Subject:</B> AW:
> [JBoss-dev] 
>   Web-Inf Deployment and MainDeployer<BR><BR></FONT></DIV>
>   <DIV><SPAN class=576305116-07022002><FONT face=Arial color=#0000ff 
>   size=2>Hi,</FONT></SPAN></DIV>
>   <BLOCKQUOTE dir=ltr style="MARGIN-RIGHT: 0px">
>     <DIV></DIV>
>     <DIV class=OutlookMessageHeader lang=de dir=ltr align=left><FONT
> face=Tahoma 
>     size=2>-----Urspr�ngliche Nachricht-----<BR><B>Von:</B> marc fleury 
>     [mailto:[EMAIL PROTECTED]] <BR><B>Gesendet:</B> Donnerstag, 7.
> Februar 
>     2002 20:55<BR><B>An:</B> Jung , Dr. Christoph; 
>     [EMAIL PROTECTED]<BR><B>Betreff:</B> RE:
> [JBoss-dev] 
>     Web-Inf Deployment and MainDeployer<BR><BR></FONT></DIV>
>     <DIV><FONT face="Courier New"><FONT color=#0000ff><FONT size=2><SPAN 
>     class=842425219-07022002></SPAN></FONT></FONT></FONT>&nbsp;</DIV>
>     <DIV><FONT face="Courier New"><FONT color=#0000ff><FONT size=2><SPAN 
>     class=842425219-07022002><FONT face=Arial>I don't understand this
> patch but 
>     I will do it, its ok</FONT></SPAN></FONT></FONT></FONT></DIV>
>     <DIV><FONT face="Courier New"><FONT color=#0000ff><FONT size=2><SPAN 
>     class=842425219-07022002></SPAN></FONT></FONT></FONT>&nbsp;</DIV>
>     <DIV><SPAN class=576305116-07022002><FONT face="Courier New"
> color=#0000ff 
>     size=2>instead of complaining about non-jar&nbsp;urls
> (directory)&nbsp;in 
>     the DeploymentInfo.localUrl, the WebContainer will simply take them
> as they 
>     are (not trying to extract web-inf classes).</FONT></SPAN></DIV>
>     <DIV><SPAN class=576305116-07022002><FONT face=Arial color=#0000ff 
>     size=2></FONT></SPAN>&nbsp;</DIV>
>     <BLOCKQUOTE dir=ltr 
>     style="PADDING-LEFT: 5px; MARGIN-LEFT: 5px; BORDER-LEFT: #0000ff 2px
> solid; MARGIN-RIGHT: 0px">
>       <P><FONT face=Arial size=2>The second patch splits the current 
>       MainDeployer.deploy(DeploymentInfo) method into two phases. A first
> phase 
>       that just creates classloaders and registers the deployment and a
> second 
>       phase that performs the actual deploy at the target deployers. This
> 
>       ensures that, e.g., if you have an ear consisting of an ejb-jar and
> 
>       a</FONT></P>
>       <P><SPAN class=842425219-07022002><FONT face=Arial><FONT 
>       color=#0000ff><FONT size=2>Deploy is ALREADY&nbsp;split into 
>       two&nbsp;phases init and deploy.&nbsp;&nbsp;It was done&nbsp;for
> the 
>       ear.&nbsp; Can you make sure you can't fit your stuff in Init/start
> as 
>       opposed to going to&nbsp;a 3 phase creation?<SPAN 
>       class=576305116-07022002>&nbsp;</SPAN></FONT></FONT></FONT></SPAN></P>
>       <P><SPAN class=842425219-07022002><FONT face=Arial><FONT 
>       color=#0000ff><FONT size=2><SPAN class=576305116-07022002>Oh, I did
> not 
>       touch the actual Deployer�s structure. It�s just the 
>       Maindeployer.deploySubPackages that needs a split while treating
> the 
>       subdeployments ... C</SPAN></FONT></FONT></FONT></SPAN><SPAN 
>       class=842425219-07022002><FONT face=Arial><FONT color=#0000ff><FONT
> 
>       size=2><SPAN class=576305116-07022002>lassloader creation must
> happen 
>       already in the first loop that collects the jarentries and sets up 
>       DeploymentInfos such that&nbsp;all classes are already available
> for 
>       the&nbsp;upcoming init/deploy calls&nbsp;of the actual Deployers,
> no 
>       matter in what order.</SPAN></FONT></FONT></FONT></SPAN></P>
>       <P><SPAN class=842425219-07022002><FONT face=Arial><FONT 
>       color=#0000ff><FONT size=2><SPAN class=576305116-07022002>I have
> attached 
>       the full files this time, because diffs are difficult to read (and
> my 
>       comments even more, I know).</SPAN></FONT></FONT></FONT></SPAN></P>
>       <P><SPAN class=842425219-07022002><FONT face=Arial><FONT 
>       color=#0000ff><FONT size=2><SPAN 
>       class=576305116-07022002>CGJ</SPAN></FONT></FONT></FONT></SPAN></P>
>       <P><SPAN class=842425219-07022002><FONT face=Arial><FONT 
>       color=#0000ff><FONT size=2><SPAN 
>       
>class=576305116-07022002></SPAN></FONT></FONT></FONT></SPAN>&nbsp;</P></BLOCKQUOTE></BLOCKQUOTE></BLOCKQUOTE></BODY></HTML>
> 

_______________________________________________
Jboss-development mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/jboss-development

Reply via email to