If it makes the build faster then do it. Removing imports won't change any logic.
--jason At 11:38 AM 2/7/2002 -0500, Guillaume Boissiere wrote: >Hi Jason, > >Sounds good to me, it's one of those things, it never feels like it's >a good time to do because it touches so much code. > >So let me do this: I'll run my script, test that it works well and >does not break things and commit the changes to CVS HEAD this week-end >unless someone complains. > >So if this is a bad time for anyone, time to speak up!! > >-- Guillaume > > > > > -----Original Message----- > > From: nobody [mailto:[EMAIL PROTECTED]]On Behalf Of > > [EMAIL PROTECTED] > > Sent: Wednesday, February 06, 2002 7:56 PM > > To: [EMAIL PROTECTED] > > Subject: [ jboss-Patches-475080 ] Remove dead imports from jboss-all > > > > > > Patches item #475080, was opened at 2001-10-25 15:05 > > You can respond by visiting: > > http://sourceforge.net/tracker/?func=detail&atid=376687&aid=475080 > > &group_id=22866 > > > > Category: JBossServer > > Group: v3.0 Rabbit Hole (unstable) > > Status: Open > > Resolution: None > > Priority: 5 > > Submitted By: Guillaume Boissiere (boissier) > > Assigned to: Nobody/Anonymous (nobody) > > Summary: Remove dead imports from jboss-all > > > > Initial Comment: > > Would you believe that there are 2065 lines of > > import x.y.z; where the class is imported but not used? > > > > I put together a script that parses through the source > > code (in jboss-all) and removes all those unnecessary > > import lines. > > The result: a performance improvement of almost 10% in > > the time it takes to compile the whole project... > > > > Here is the long patch attached that removes all these > > extra lines. Patch is lightly tested and after > > applying it, the project compiles just fine. > > Enjoy! > > > > -- Guillaume > > > > PS: I noticed a couple files have CR+CR+LF at the end > > of each line instead of the more standard CR+LF, CR or > > LF... I had trouble with those (ex: EJBAdaptorBean) > > so they are not included here. > > > > ---------------------------------------------------------------------- > > > > >Comment By: Jason Dillon (user57) > > Date: 2002-02-06 16:55 > > > > Message: > > Logged In: YES > > user_id=15045 > > > > How about submitting the script which does this. Things > > have changed a bit since this was posted. I think it > > might be more work to apply the patch (and deal with the > > conflicts) than to just run the script again. > > > > If this is not an issue any more let me know so I can > > close this. > > _______________________________________________ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
