User: user57
Date: 02/02/12 16:15:01
Modified: src/main/org/jboss/mq/server QueueManager.java
TopicManager.java
Log:
o Changed logger cat seperator to '.' for consistency. I don't like it
really, but I figure that if debugging a problem one would look at the
full log file, so this is just for some confirmation that things are
working
o Changed error to warn for stopService(), as there isn't anything to
really do about this at the moment.
o Unmasking a rethrown exception
Revision Changes Path
1.12 +6 -4 jbossmq/src/main/org/jboss/mq/server/QueueManager.java
Index: QueueManager.java
===================================================================
RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/server/QueueManager.java,v
retrieving revision 1.11
retrieving revision 1.12
diff -u -r1.11 -r1.12
--- QueueManager.java 11 Feb 2002 22:45:28 -0000 1.11
+++ QueueManager.java 13 Feb 2002 00:15:01 -0000 1.12
@@ -33,7 +33,7 @@
*
* @author Norbert Lataille ([EMAIL PROTECTED])
* @author <a href="[EMAIL PROTECTED]">Hiram Chirino</a>
- * @version $Revision: 1.11 $
+ * @version $Revision: 1.12 $
*/
public class QueueManager
extends ServiceMBeanSupport
@@ -127,13 +127,15 @@
else
setJNDIName(jndiName); //in config phase, all we did was store the name,
and not actually bind
}
- catch (JMSException e) {log.warn("Couldn't add queue "+e.getMessage());}
+ catch (JMSException e) {
+ log.warn("Couldn't add queue", e);
+ }
}
protected void stopService()
{
- log.error("queue stop not yet implemented");
+ log.warn("queue stop not yet implemented");
}
protected ObjectName getObjectName(MBeanServer server, ObjectName name) throws
javax.management.MalformedObjectNameException
@@ -145,7 +147,7 @@
}
// re-setup the logger with a more descriptive name
- log = Logger.getLogger(getClass().getName() + ":" + queueName);
+ log = Logger.getLogger(getClass().getName() + "." + queueName);
return name;
}
1.13 +8 -5 jbossmq/src/main/org/jboss/mq/server/TopicManager.java
Index: TopicManager.java
===================================================================
RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/server/TopicManager.java,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -r1.12 -r1.13
--- TopicManager.java 11 Feb 2002 22:45:28 -0000 1.12
+++ TopicManager.java 13 Feb 2002 00:15:01 -0000 1.13
@@ -36,7 +36,7 @@
*
* @author Norbert Lataille ([EMAIL PROTECTED])
* @author <a href="[EMAIL PROTECTED]">Hiram Chirino</a>
-* @version $Revision: 1.12 $
+* @version $Revision: 1.13 $
*/
public class TopicManager
extends ServiceMBeanSupport
@@ -129,7 +129,9 @@
else
setJNDIName(jndiName); //In config phase, we only stored the name, and
didn't actually bind it
}
- catch (JMSException e) {log.warn("Couldn't add topic "+e.getMessage());}
+ catch (JMSException e) {
+ log.warn("Couldn't add topic", e);
+ }
}
@@ -137,10 +139,11 @@
{
// FIXME marcf: implement the removal of the service
// The behavior to be fixed is a "rebuild the server, it hot deploys,
destination exists"
- log.error("queue stop not yet implemented");
+ log.warn("queue stop not yet implemented");
}
- protected ObjectName getObjectName(MBeanServer server, ObjectName name) throws
javax.management.MalformedObjectNameException
+ protected ObjectName getObjectName(MBeanServer server, ObjectName name)
+ throws javax.management.MalformedObjectNameException
{
topicName = name.getKeyProperty("name");
if (topicName == null || topicName.length() == 0)
@@ -149,7 +152,7 @@
}
// re-setup the logger with a more descriptive name
- log = Logger.getLogger(getClass().getName() + ":" + topicName);
+ log = Logger.getLogger(getClass().getName() + "." + topicName);
return name;
}
_______________________________________________
Jboss-development mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/jboss-development
