Patches item #518597, was opened at 2002-02-16 14:21
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=376687&aid=518597&group_id=22866

Category: JBossCMP
Group: v3.0 Rabbit Hole (unstable)
Status: Open
Resolution: None
Priority: 5
Submitted By: Georg Schmid (giorgio42)
Assigned to: Nobody/Anonymous (nobody)
Summary: Wrap log stmts in JDBCStoreEntitiyCommnd

Initial Comment:

This patch is related to bug #512826 (RH shows
quadratic behaviour on inserts).

It guards the log statements in this
file with if (log.isDebugEnabled()) { ... }.

Index: JDBCStoreEntityCommand.java
=======================================================
============
RCS 
file: /cvsroot/jboss/jboss/src/main/org/jboss/ejb/plugi
ns/cmp/jdbc/JDBCStoreEntityCommand.ja
va,v
retrieving revision 1.11
diff -u -r1.11 JDBCStoreEntityCommand.java
--- JDBCStoreEntityCommand.java 15 Jan 2002 22:27:34 -
0000      1.11
+++ JDBCStoreEntityCommand.java 16 Feb 2002 21:50:39 -
0000
@@ -51,8 +51,10 @@
       List dirtyFields = entity.getDirtyFields(ctx);

       if(dirtyFields.isEmpty()) {
-         log.debug("Store command NOT executed. 
Entity is not dirty: pk=" +
-               ctx.getId());
+         if (log.isDebugEnabled()) {
+            log.debug("Store command NOT executed. 
Entity is not dirty: pk=" +
+                      ctx.getId());
+         }
          return;
       }

@@ -71,7 +73,9 @@
          con = entity.getDataSource().getConnection();

          // create the statement
-         log.debug("Executing SQL: " + sql);
+         if (log.isDebugEnabled()) {
+            log.debug("Executing SQL: " + sql);
+         }
          ps = con.prepareStatement(sql.toString());

          // set the parameters
@@ -99,7 +103,9 @@
                "affected row: rowsAffected=" + 
rowsAffected +
                "id=" + ctx.getId());
       }
-      log.debug("Create: Rows affected = " + 
rowsAffected);
+      if (log.isDebugEnabled()) {
+         log.debug("Create: Rows affected = " + 
rowsAffected);
+      }

       // Mark the inserted fields as clean.
       for(Iterator iter = dirtyFields.iterator(); 
iter.hasNext(); ) {

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=376687&aid=518597&group_id=22866

_______________________________________________
Jboss-development mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/jboss-development

Reply via email to