response is at the bottom.

>From: Jason Dillon <[EMAIL PROTECTED]>
>Reply-To: [EMAIL PROTECTED]
>To: [EMAIL PROTECTED]
>Subject: Re: [JBoss-dev] CVS update: jboss/src/main/org/jboss/system 
>UnifiedClassLoader.java
>Date: Fri, 22 Feb 2002 01:55:53 -0600
>
> > On Thu, 21 Feb 2002, Hiram Chirino wrote:
> >
> > >   User: chirino
> > >   Date: 02/02/21 15:17:00
> > >
> > >   Modified:    src/main/org/jboss/system
> > UnifiedClassLoader.java
> > >   Log:
> > >   Adding new Boot class that helps out with
> > creating a embedable JBoss app server.
> > >   embedable in the small footprint sense and
> > enbedable in the integrate with an existing app
> > sense.
> > >
> > >   Revision  Changes    Path
> > >   1.8       +2 -2
> >
> >
> >
> >
> >  jboss/src/main/org/jboss/system/UnifiedClassLoader.ja
> > a
> > >
> > >   Index: UnifiedClassLoader.java
> > >
> >
> >  =====================================================
> > =============
> > >   RCS file:
> > /cvsroot/jboss/jboss/src/main/org/jboss/system/Unified
> > lassLoader.java,v
> > >   retrieving revision 1.7
> > >   retrieving revision 1.8
> > >   diff -u -r1.7 -r1.8
> > >   --- UnifiedClassLoader.java     17 Feb 2002 21:40:15
> > -0000       1.7
> > >   +++ UnifiedClassLoader.java     21 Feb 2002 23:17:00
> > -0000       1.8
> > >   @@ -20,7 +20,7 @@
> > >     * @author <a href="[EMAIL PROTECTED]">Marc
> > Fleury</a>
> > >     * @author <a
> > href="[EMAIL PROTECTED]">Christoph G. Jung</a>
> > >     * @author <a href="[EMAIL PROTECTED]">Scott
> > Stark/a>
> > >   - * @version $Revision: 1.7 $
> > >   + * @version $Revision: 1.8 $
> > >     *
> > >     * <p><b>20010830 marc fleury:</b>
> > >     * <ul>
> > >   @@ -56,7 +56,7 @@
> > >        */
> > >       public UnifiedClassLoader(URL url)
> > >       {
> > >   -      super(new URL[] {url});
> > >   +      super(new URL[] {url},
> > UnifiedClassLoader.class.getClassLoader());
> >
> > Wouldn't getClass().getClassLoader() be better here?
> >
> > It would allow for the case where UnifiedClassLoader
> > is extended by sub
> > classes.
>
>getClass() can not be called until the superclass finishes initializing.
>
>Why not use Thread.currentThread().getContextClassLoader() here?
>
>--jason
>

I'm not a supper expert on the UnifiedClassLoader, but I made an assumption 
that ALL the UnifiedClassLoader instances should have the same classloader 
parent.  I made this assumption since previously, they all had the System 
Classloader as the parent.

If you use Thread.currentTread().getContextClassLoader(), you open up the 
possibility that they could have different ClassLoader parents depending on 
the context that you create the UCL in.

Regards,
Hiram

_________________________________________________________________
MSN Photos is the easiest way to share and print your photos: 
http://photos.msn.com/support/worldwide.aspx


_______________________________________________
Jboss-development mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/jboss-development

Reply via email to