I just finished seperating the directory based deployment scanning from MainDeployer into an abstraction call DeploymentScanner. DS provides a simple interface, which currently is purly administrative in functionality.
I created a local directory specific DS, DirectoryDeploymentScanner, which provides the ability to a set of files and directories for files which it then turns around and invokes MainDeployer.deploy() or MainDeployer.undeploy() to finish the job. I started out with different intentions when I did this, but ended up basically copying the bits from MD more or less verbatim to get this to work. I had also though that the DeployerMBean interface still had deploy() and undeploy() methods, and thus planned on making the target deployer configurable through a depends attribute. Currently, if you look at the config, there is still a depends, as this MBean needs the MD to be started to function, but the linkage is hard coded to the MainDeployerMBean.OBJECT_NAME. I was also not planning on letting DeploymentInfo seep into this layer... but after thinking and attempting to implement this in a different way, re-using this turned out to be the easiest and simpelest way to get this finished. I hope that this can be sorted out later, as right now it is not idea. The DS retains a set of DI objects which is only needs to know the lastModified for, and then MainDeployer also manages a list/has of these. I think that this could be fixed up with a combonation of David's xslt ideas + the Deployment/DeploymentManager bits I was talking about when I mentiond DeploymentScanner in the first place. For DDS, since it is file specific I removed the small bits of code which got the last modified time from an opened connection. The reason I did this was to keep the DDS simple by making it only have to worry about files and that is it. I think that if this is re-added, then a URLDeploymentScanner can created which can tailor to its needs. Possibly making use of the content/type to further determine what type of data is there. At which point that occurs, we also should setup a DeploymentScannerSupport to hold the common bits between all types of scanners. --jason _______________________________________________ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
