Thanks David, I'll download the JSR77 spec, to see what it all about.
The other problem is, that JSR77 has the same ObjectName problems as we found with EjbModule. Try deploying My=App.ear and you get a MalformedObjectName exception :-) Regards, Adrian > On 2002.03.02 22:00:15 -0500 Adrian Brock wrote: > > You are correct, I didn't read the bug report very > well. > > > > When I fixed the windows locking problem for ears, > > I saw the same exception. I thought it was the same > > problem. > > > > I've been making too many errors this week. > > I think I *need* a day off. :-) > > I know the feeling. I'll see about fixing this one- > I think I can do it > very easily, at least so it does something > reasonable. > > david jencks > > > > Regards, > > Adrian > > > > > > > Hi Adrian, > > > > > > I'm not very familiar with jsr-77 either, and > despite > > > repeated explanations > > > from Andreas I keep having difficulty > understanding > > > what problem it is > > > solving ;-) > > > > > > I've started wondering if there is some way of > > > eliminating the current > > > jsr-77 mbeans and providing the entire > implementation > > > as some kind of view > > > on modelmbeans (when all our current mbeans are > > > model-ified) -- maybe using > > > some descriptor to indicate what is "jsr-77" > > > > > > We need to find out what jsr-77 allows for x > being > > > the parent of y, since > > > our deployment now allows just about anything. > > > Eventually the "parent" > > > gets up to the jboss node. I don't know if in a > > > cluster it continues > > > higher;-). Andreas has some code in > > > org.jboss.ejb.EjbModule that creates a > > > jsr-77 parent if the deployment info has no > parent; > > > this is a deployment of > > > a plain ejb-jar. I'm not thrilled with this > > > psuedo-application that > > > doesn't correspond to anything on the server. I > > > think this code should be > > > moved to the jsr-77 ejb module mbean, and it > should > > > create a parent > > > whenever it can't find one. maybe there is a way > to > > > have it make more > > > sense in general -- like including an application > > > name in jboss.xml, so > > > several ejb-jars can be deployed into one > > > "application" without putting > > > them in an ear. > > > > > > > > > Another possibility is to rather than set the > parent > > > explicitly, have the > > > jsr-77 mbean try to figure it out when asked by > > > looking at the underlying > > > mbean. This might completely sidestep the > problem. > > > > > > I keep wondering, did your change actually fix > the > > > problem when an ejb-jar > > > is in a sar? I haven't tested it, but I have > trouble > > > imagining how it could > > > since the sar isn't deployed with the > eardeployer. > > > > > > Thanks > > > > > > david jencks > > > > > > On 2002.03.02 20:55:07 -0500 Adrian Brock wrote: > > > > Hi David, > > > > > > > > I've only just started looking at the new > Deployer > > > and > > > > I'm not familiar with JSR77. > > > > > > > > But, like you say, the problem is that JSR77 > > > > tries to do everything in one step. > > > > > > > > Creating the MBeans in create and linking them > in > > > start > > > > is a general solution to the problem. > > > > > > > > The current code doesn't allow a managed object > > > > without a parent however. > > > > > > > > Regards, > > > > Adrian > > > > > > > > > IMO we either need to create every jsr-77 > mbean > > > in > > > > > the init phase of the > > > > > appropriate deployer or deployment activity, > or > > > > > create the jsr-77 mbeans in > > > > > create and set their parents in start. We > also > > > need > > > > > to deal with jsr-77 > > > > > mbeans for non-j2ee packages such as sars, > and > > > > > non-j2ee nesting such as ear > > > > > in ear or ear in ejb-jar. These will deploy > just > > > > > fine except for the > > > > > jsr-77 stuff. > > > > > > > > > > The current setup will not work for ejb-jar > in > > > > > ejb-jar, for 2 reasons: > > > > > > > > > > 1. same problem you fixed here, inside create > > > called > > > > > first. > > > > > > > > > > 2. jsr-77 stuff doesn't expect this (non > j2ee) > > > > > nesting. > > > > > > > > > > david jencks > > > > > > > > > > > > > > > On 2002.03.02 18:22:10 -0500 Adrian Brock > wrote: > > > > > > User: ejort > > > > > > Date: 02/03/02 15:22:10 > > > > > > > > > > > > Modified: > src/main/org/jboss/deployment > > > > > EARDeployer.java > > > > > > Log: > > > > > > Create the JSR77 appliction in init. > > > Sub-module > > > > > creation comes before > > > > > > application creation. The sub-modules JSR77 > > > mbeans > > > > > need the application > > > > > > mbean to exist > > > > > > > > > > > > > > > > Revision Changes Path > > > > > > 1.10 +9 -10 > > > > > > > > > > > > > > > > > > > > > > > > jboss/src/main/org/jboss/deployment/EARDeployer.java > > > > > > > > > > > > Index: EARDeployer.java > > > > > > > > > > > > > > > > > > > > ===================================================== > > > > > ============= > > > > > > RCS file: > > > > > > > > > /cvsroot/jboss/jboss/src/main/org/jboss/deployment/EAR > > > > > eployer.java,v > > > > > > retrieving revision 1.9 > > > > > > retrieving revision 1.10 > > > > > > diff -u -r1.9 -r1.10 > > > > > > --- EARDeployer.java 2 Mar 2002 16:34:25 > > > > > -0000 1.9 > > > > > > +++ EARDeployer.java 2 Mar 2002 23:22:10 > > > > > -0000 1.10 > > > > > > @@ -49,7 +49,7 @@ > > > > > > /** > > > > > > * > > > > > > * @author <a > > > > > href="mailto:[EMAIL PROTECTED]";>Marc > > > Fleury</a> > > > > > > -* @version $Revision: 1.9 $ > > > > > > +* @version $Revision: 1.10 $ > > > > > > */ > > > > > > public class EARDeployer > > > > > > extends ServiceMBeanSupport > > > > > > @@ -130,21 +130,20 @@ > > > > > > log.error("Error in init step > of > > > ear > > > > > deployment", e); > > > > > > throw new > > > DeploymentException("Error in > > > > > accessing application > > > > > > metadata: ", e); > > > > > > } > > > > > > - > > > > > > + // Create the appropriate JSR-77 > > > instance, > > > > > this has to be done > > > > > > in init > > > > > > + // EAR create is called after > > > > > sub-component creates that need > > > > > > this MBean > > > > > > + ObjectName lApplication = > > > > > J2EEApplication.create( > > > > > > + server, > > > > > > + di.shortName, > > > > > > + di.localUrl > > > > > > + ); > > > > > > } > > > > > > > > > > > > > > > > > > public void create(DeploymentInfo di) > > > > > > throws DeploymentException > > > > > > { > > > > > > - // now try to deploy > > > > > > - log.info("Deploying J2EE > application, > > > > > create step: " + di.url); > > > > > > - // Create the appropriate JSR-77 > > > instance > > > > > > - ObjectName lApplication = > > > > > J2EEApplication.create( > > > > > > - server, > > > > > > - di.shortName, > > > > > > - di.localUrl > > > > > > - ); > > > > > > + log.info("Deploying J2EE > application, > > > > > create step, a no-op: " + > > > > > > di.url); > > > > > > } > > > > > > > > > > > > public void start(DeploymentInfo di) > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > > > > Jboss-development mailing list > > > > > > [EMAIL PROTECTED] > > > > > > > > > > > > > > > https://lists.sourceforge.net/lists/listinfo/jboss-dev > > > > > lopment > > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > > > Jboss-development mailing list > > > > > [EMAIL PROTECTED] > > > > > > > > > https://lists.sourceforge.net/lists/listinfo/jboss-dev > > > > > lopment > > > > > > > > > > > > > > > > > > > > ______________________________________________________ > > > __ > > > > View thread online: > > > > http://main.jboss.org/thread.jsp?forum=66&thread=7125 > > > > > > > > _______________________________________________ > > > > Jboss-development mailing list > > > > [EMAIL PROTECTED] > > > > > > > > https://lists.sourceforge.net/lists/listinfo/jboss-dev > > > lopment > > > > > > > > > > > > > > _______________________________________________ > > > Jboss-development mailing list > > > [EMAIL PROTECTED] > > > > https://lists.sourceforge.net/lists/listinfo/jboss-dev > > > lopment > > > > > > > > > ______________________________________________________ > __ > > View thread online: > http://main.jboss.org/thread.jsp?forum=66&thread=7125 > > > > _______________________________________________ > > Jboss-development mailing list > > [EMAIL PROTECTED] > > > https://lists.sourceforge.net/lists/listinfo/jboss-dev > lopment > > > > > > _______________________________________________ > Jboss-development mailing list > [EMAIL PROTECTED] > https://lists.sourceforge.net/lists/listinfo/jboss-dev > lopment _________________________________________________________ View thread online: http://main.jboss.org/thread.jsp?forum=66&thread=7125 _______________________________________________ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
