I agree with both of you... I think Larry's addition is valuable functionality, since we can already deploy single URLS. However the way it works, as Jason points out, is not so good.
How about if there are 2 properties on the scanner: a list of single urls, that can be packages or directories, and a list of directories to scan? Then the user has to decide what they are trying to do;-) david jencks On 2002.04.14 14:15:37 -0400 Larry Sanderson wrote: > Was the scanner ever intended to watch a single deployable file? Or just > watch a directory containing deployable files? > > If it was just for watching a directory, then I agree... this patch does > not belong here. In this case, a second scanner should be developed to > just deployable units (with no watching sub directories). If this is > done, should the current scanner be limited to only watching directories? > Currently it does monitor both. > > Let me know how to procede. Thanks. > > -Larry > > > First glance makes me think this functionality does not > > belong here... with this patch the scanner now needs to > > have access to subdeployer like functionality. > > > > I would prefer to keep UDS simple, and I believe that this > > patch (perhaps some of the other patches too, not sure) > > complicate this very simple component. > > > > I think that a sub-class would be better suited here, so > > we can keep the basic UDS functionality pure and simple. > > > > I would look into other ways to perform the same > > functionality... as this isDeplyable() method will become > > a maintenece problem... as subdeployers are added and > > removed this will need to change. > > > > Basicially I think this is a hack of an already hacked up > > deployment system. If you are set on adding this, then > > special case it with a subclass.... or help redesign the > > deployment system by adding this functionality to the list > > of requirements. > > > > --jason > _________________________________________________________ > View thread online: http://main.jboss.org/thread.jsp?forum=66&thread=12891 > > _______________________________________________ > Jboss-development mailing list > [EMAIL PROTECTED] > https://lists.sourceforge.net/lists/listinfo/jboss-development > > _______________________________________________ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
