Jason, why don't you be that JSP maintainer. It seems to me that it would really give the JBoss version a small edge compared to the other straight tomcat distributions and I am all about edge. It needs to be maintained by at least 2 people.
You know what to do, marcf |-----Original Message----- |From: [EMAIL PROTECTED] |[mailto:[EMAIL PROTECTED]]On Behalf Of Greg |Wilkins |Sent: Sunday, April 28, 2002 6:37 AM |To: [EMAIL PROTECTED] |Cc: [EMAIL PROTECTED] |Subject: [JBoss-dev] Re: [jetty-discuss] Last-Modified, |If-Modified-Since & Jasper | | | |I have yet to find a tame Jasper developer. I can't even find a JSPs |maintainer that is willing to liase with the tomcat folks. | |I think that you best bet is to just try the tomcat-dev list and |see who/what |you find. | |I really don't want to put any changes into jasper in Jetty that |are not going |to be in a real jasper release in a sort time. I suggest that we take the |same position with jboss CVS. Unless we have a JSP hero who |wants to maintain |the different version - it is best to be the same, warts and all! | |Note that it is not clear what the modified time should be that a JSP is |checked against - so there may be a problem finding a general solution |to this problem (even if/when you can modify the code). | |cheers | | | |Jason Dillon wrote: |> Hello, I have been looking into problems with trying to enable |proper support |> for caching jsp pages running inside of Jetty... and I think I |have found the |> problem... Jasper. |> |> The Jasper JSP servlet overrides service(HttpServletRequest, |> HttpServletResponse) (with a final version no less), that simply invokes |> _jspService() thus bypassing the Last-Modified & |If-Modified-Since logic in |> HttpServlet.service(HttpServletRequest, HttpServletResponse). |> |> This means that even if a JSP sets the Last-Modified header |manually the page |> will still not be handled properly by a web cache because the |If-Modified- |> Since logic is not avilable to provide it with efficent validation. |> |> Also, since the puppy is final the user must override |service(ServletRequest, |> ServletResponse) then cast the request and respons, then |duplicate the code in |> HttpServlet.service(HttpServletRequest, HttpServletResponse) |which deals with |> GET requests, then call _jspSevice() to render the page. |> |> For a test, I changed HttpJspBase to not override service, |instead override |> doGet() which invokes _jspService() then with my jsp set proper |headers and |> override getLastModified(). With these changes the generated |page is now |> cache friendly... meaning that a caching web proxy like squid |can now cache |> the page correcttly. |> |> I just checked that the version of HttpJspBase in the Jetty CVS |is the same as |> the version imported into JBoss CVS... and if Jasper was |refreshed last week |> then it appears this is still an issue. |> |> I have not yet tested if the newly imported Jasper sources |correctly handle |> xml-like jsp tags either... but my guess is that it does not. |> |> So, what is the deal with Jasper? Is there one on this list who |has rw for |> it? I am guessing this is nested somwhere inside of the Tomcat |sources... but |> I don't know. There does not appear to be a Jasper project... |from looking at |> the CVS tree there is a jakarta-tomcat-jasper module, which also |has the same |> HttpJspBase. |> |> So, my question is what is the policy for changing this source? Is this |> imported Jasper being maintained locally or are you/we relying on the |> Tomcat/Jasper folks to fix bugs and correctly implement the JSP |(as well as |> Servlet) spec? |> |> --jason |> |> ------------------------------------------------- |> This mail sent through IMP: http://horde.org/imp/ |> |> ------------------------ Yahoo! Groups Sponsor ---------------------~--> |> Tied to your PC? Cut Loose and |> Stay connected with Yahoo! Mobile |> http://us.click.yahoo.com/QBCcSD/o1CEAA/yigFAA/CefplB/TM |> ---------------------------------------------------------------------~-> |> |> For the latest information about Jetty, please see http://jetty.mortbay.org > > To alter your subscription to this list goto http://groups.yahoo.com/group/jetty-discuss > > Your use of Yahoo! Groups is subject to http://docs.yahoo.com/info/terms/ > -- Greg Wilkins<[EMAIL PROTECTED]> GB Phone: +44-(0)7092063462 Mort Bay Consulting Australia and UK. Mbl Phone: +61-(0)4 17786631 http://www.mortbay.com AU Phone: +61-(0)2 98107029 _______________________________________________ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development _______________________________________________ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
