Hi Adrian, > 3.0RC4 > The testsuite doesn't hang, and it passes a simple test that > failed on the > previous version (I'll add it to the testsuite this weekend + > other more > complicated tests). Thanks for applying this.
I saw also HEAD passed tonight :) Can I sak you to link to the testsuite also a testcase that Sacha submitted, and that is now under testuite/.../classloader/concurrentload ? I am still not that familiar with the testuite :P > I think there is still a problem with the ordering for > findClass(String) (and possibly getURLs() - but not very likely) > It will lock "this" before the reentrantLock which is the opposite of > loadClass(String, boolean, ClassLoader). Yes, but those 2 methods are called rarely. Also, it is not possible to implement them just calling reentrantLock.acquire/release, as I need also the logic of isThreadAllowed() to set the current thread (and this would mean to call synchronize, but I don't have the classloader to wait on). Not a big deal, but on which object make the thread waiting ? I thought as a first try to leave them as is, to see if tha last changes were working. > Also is synchronizing on "lock" necessary? It is already > synchronized on > the rentrantLock for these private methods. > Is there a reason why these methods can't be inlined to save on stack > opertions? No, I guess it can be removed now. I will work on it later this afternoon, or this weekend. Thanks for the feedback ! Cheers Simon _______________________________________________________________ Don't miss the 2002 Sprint PCS Application Developer's Conference August 25-28 in Las Vegas -- http://devcon.sprintpcs.com/adp/index.cfm _______________________________________________ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
