Bugs item #600837, was opened at 2002-08-27 17:20 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=376685&aid=600837&group_id=22866
Category: JBossServer Group: v3.0 Rabbit Hole >Status: Closed >Resolution: Fixed Priority: 5 Submitted By: Dain Sundstrom (dsundstrom) Assigned to: Christian Riege (lqd) Summary: Verifier: ejb-jar.xml DOCTYPE required Initial Comment: The DOCTYPE declaration in the ejb-jar.xml file is required, but the verifier does not enforce this. EJB 2.0 spec page 161: All valid ejb-jar deployment descriptors must contain the following DOCTYPE declaration: <!DOCTYPE ejb-jar PUBLIC "-//Sun Microsystems, Inc.//DTD Enterprise JavaBeans 2.0//EN" "http://java.sun.com/dtd/ejb-jar_2_0.dtd";> ---------------------------------------------------------------------- >Comment By: Christian Riege (lqd) Date: 2002-08-28 11:50 Message: Logged In: YES user_id=176671 i've changed this in HEAD and 3.2. See also SF ChangeNote: http://sourceforge.net/tracker/index.php?func=detail&aid=601185&group_id=22866&atid=381174 if it breaks your deployments don't bitch but change your DOCTYPE declaration :). ---------------------------------------------------------------------- Comment By: Christian Riege (lqd) Date: 2002-08-27 19:04 Message: Logged In: YES user_id=176671 So JBoss should throw a DeploymentException if no valid DOCTYPE (1.1 or 2.0 at the moment) is found? I'll leave it at the ApplicationMetaData.java level though as the Verifier should only kick in after the ejb-jar.xml has been read and validated. Do you think this should also go into 3.2 release or should I leave it at 4.0 for the time being? I have a rough sketch of a re-write of the Verifier for JBoss 4.0; matter of fact is that I think that we can pull out a lot of the checking that is currently going on in the CMR code at run-time into the deployment step. We should have a close look at this when you start implementing the CMP/CMR stuff for 4.0 -- i.e. your new engine shouldn't worry about the data being passed into it as this data will already have been verified. Does this make sense? ---------------------------------------------------------------------- Comment By: Dain Sundstrom (dsundstrom) Date: 2002-08-27 18:46 Message: Logged In: YES user_id=251431 Yes, but the verifier chan check that the document contains a correct doctype after the document is parsed. The ejb 1.1 also requires a doctype declaration, so the code should sheck that the document has a doctype decl and that it is either 1.1 or 2.0. ---------------------------------------------------------------------- Comment By: Christian Riege (lqd) Date: 2002-08-27 18:22 Message: Logged In: YES user_id=176671 i don't think this is an issue w/ the verifier as the BeanVerifier gets handed an already parsed ejb-jar.xml ATM. According to the code in org.jboss.metadata.ApplicationMetadata i don't see how you can get 2.0 ejb-jar.xml behaviour w/ no valid 2.0 DOCTYPE declaration but maybe i'm missing your point? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=376685&aid=600837&group_id=22866 ------------------------------------------------------- This sf.net email is sponsored by: Jabber - The world's fastest growing real-time communications platform! Don't just IM. Build it in! http://www.jabber.com/osdn/xim _______________________________________________ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
