Bugs item #643732, was opened at 2002-11-25 14:36 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=376685&aid=643732&group_id=22866
Category: JBossServer Group: CVS HEAD Status: Open >Resolution: Fixed Priority: 5 Submitted By: Michael Newcomb (mnewcomb) Assigned to: Nobody/Anonymous (nobody) Summary: MainDeployer can't undeploy bad EARs Initial Comment: Facts about MainDeployer: - all deployments (DeploymentInfo), both good or bad, go into a List called deploymentList when MainDeployer.init() completes (in a finally clause) - all deployments that that do not fail their DeploymentInfo.deployer.init() calls go into a Map called deploymentMap (DeploymentInfo.url to DeploymentInfo) This can cause problems when the DeploymentInfo.deployer throws a DeploymentException. The DeploymentInfo does not get inserted into the deploymentMap and can therefore never be removed. Any call to MainDeployer.undeploy() fails quietly because there is no entry inside of deploymentMap (because the DeploymentInfo.deployer threw an exception skipping that deploymentMap.put() call). All attempts to redeploy the application (even if the errors were corrected) fall on deaf ears and the new DeploymentInfos just keep getting put into the deploymentList List (small memory leak). A simple test case to demonstrate this error: 1. create an empty EAR file (nothing in the jar file) 2. deploy it 3. watch EARDeployer throw a DeploymentException stating that META-INF/application.xml doesn't exist 4. delete the EAR file (nothing happens) 5. try to re-deploy the EAR file (valid or not) and you get a new exception about how it is waiting for an appropriate deployer The only way to redeploy the application is to restart JBoss. I fixed this problem by adding some additional code to MainDeployer.undeploy. If undeploy can't find the DeploymentInfo object in deploymentMap, it simply searches through deploymentList looking for a match. I've fixed this in CVS, just entering it here so we can track the bug. The above test should now always throw only the no META-INF/application.xml file found exception. Michael ---------------------------------------------------------------------- >Comment By: Michael Newcomb (mnewcomb) Date: 2002-11-25 14:46 Message: Logged In: YES user_id=382427 I fixed this in CVS. Can someone close this? I don't seem to have close priviledges. Thanks, Michael ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=376685&aid=643732&group_id=22866 ------------------------------------------------------- This SF.net email is sponsored by: Get the new Palm Tungsten T handheld. Power & Color in a compact size! http://ads.sourceforge.net/cgi-bin/redirect.pl?palm0002en _______________________________________________ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
