I pulled out my changes. Sorry for the troubles. -----Original Message----- From: Igor Fedorenko Sent: Friday, January 10, 2003 9:45 AM To: [EMAIL PROTECTED] Subject: RE: [JBoss-dev] Re: [jboss-cvs] jboss/src/main/org/jboss/ejb/plugins/jms JMSContainerInvoker.java
Scott, It looks like my change collided with change to MDBUnitTestCase made by ejort (Fix the testsuite so that the cache is empty after the run). I'll try to fix this asap. -----Original Message----- From: Scott M Stark [mailto:[EMAIL PROTECTED]] Sent: Friday, January 10, 2003 4:51 AM To: [EMAIL PROTECTED] Subject: [JBoss-dev] Re: [jboss-cvs] jboss/src/main/org/jboss/ejb/plugins/jms JMSContainerInvoker.java This change appears to have broken the org.jboss.test.mdb.test.MDBUnitTestCase as seen in the latest 3.2 test results. Look into this testcase please. Suite: MDBUnitTestCase Test: testQueue(org.jboss.test.mdb.test.MDBUnitTestCase) Type: error Exception: org.jboss.mq.SpyJMSException Message: Cannot get a client ID; - nested throwable: (javax.jms.JMSSecurityException: The login id has an assigned client id. That client id is already connected to the server!) xxxxxxxxxxxxxxxxxxxxxxxx Scott Stark Chief Technology Officer JBoss Group, LLC xxxxxxxxxxxxxxxxxxxxxxxx ----- Original Message ----- From: "Igor Fedorenko" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Wednesday, January 08, 2003 2:01 PM Subject: [jboss-cvs] jboss/src/main/org/jboss/ejb/plugins/jms JMSContainerInvoker.java > User: igorfie > Date: 03/01/08 14:01:43 > > Modified: src/main/org/jboss/ejb/plugins/jms Tag: Branch_3_2 > JMSContainerInvoker.java > Log: > Use ejb-name as a default for client-id, if mdb does durable topic subsction. > > Revision Changes Path > No revision > > > No revision > > > 1.50.2.1 +12 -3 >jboss/src/main/org/jboss/ejb/plugins/jms/JMSContainerInvoker.java > > Index: JMSContainerInvoker.java > =================================================================== > RCS file: >/cvsroot/jboss/jboss/src/main/org/jboss/ejb/plugins/jms/JMSContainerInvoker.java,v > retrieving revision 1.50 > retrieving revision 1.50.2.1 > diff -u -r1.50 -r1.50.2.1 > --- JMSContainerInvoker.java 28 Jul 2002 04:14:38 -0000 1.50 > +++ JMSContainerInvoker.java 8 Jan 2003 22:00:42 -0000 1.50.2.1 > @@ -54,7 +54,7 @@ > /** > * EJBProxyFactory for JMS MessageDrivenBeans > * > - * @version <tt>$Revision: 1.50 $</tt> > + * @version <tt>$Revision: 1.50.2.1 $</tt> > * @author <a href="mailto:[EMAIL PROTECTED]";>Peter Antman</a> . > * @author <a href="mailto:[EMAIL PROTECTED]";>Rickard �berg</a> > * @author <a href="mailto:[EMAIL PROTECTED]";>Sebastien Alborini</a> > @@ -458,9 +458,18 @@ > connection = tConnection; > > // Fix: ClientId must be set as the first method call after connection >creation. > - // Fix: ClientId is necessary for durable subscriptions. > - > + // Fix: ClientId must be unique among all applications. > + > String clientId = config.getClientId(); > + // ClientId is necessary for durable subscriptions. > + if (clientId == null > + && config.getSubscriptionDurability() == >MessageDrivenMetaData.DURABLE_SUBSCRIPTION) > + { > + // use MDB ejb-name as default clientId > + // Fix: ejb-name is not unique among all applications. Note however, > + // it is not any worse then client id from jboss.xml. > + clientId = config.getEjbName(); > + } > log.debug("Using client id: " + clientId); > if (clientId != null && clientId.length() > 0) > connection.setClientID(clientId); ------------------------------------------------------- This SF.NET email is sponsored by: SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See! http://www.vasoftware.com _______________________________________________ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
