On 2003.03.09 15:20 Bill Burke wrote: > > > > -----Original Message----- > > From: [EMAIL PROTECTED] > > [mailto:[EMAIL PROTECTED] Behalf Of > David > > Jencks > > Sent: Saturday, March 08, 2003 8:23 AM > > To: [EMAIL PROTECTED] > > Subject: RE: [JBoss-dev] Proposal for jboss-wide interceptor framework > > > > > > > > > > > 5. multiple interceptor chains per InvocationFactory, e.g. > > each method > > > > gets a separate interceptor chain. (Idea from current mbean > > interceptor > > > > implementation) > > > > > > > > > > Do we really need per method interceptor chains? We did not > > need them to > > > implement EJBs. > > > > > > > After working with them a little bit with mbeans for jca 1.5 > deployment, > > I conclude Yes, we absolutely need per-method interceptor chains!! they > > make life so much simpler I can't believe it. > > > > What are you planning to use? The AOP framework as is can only define > interception for Java classes and Dynamic Proxies. If you need MBean > interception, it is not there unless you want to use the Java class > interception. Or, if you want a DP you'll have to change how MBeans are > registered with the server. > > > I'm less convinced that relying on a fixed sequence of interceptor > > factories to generate every chain is the best design. I implemented a > > quick and dirty way of generating custom chains by simply looking in > the > > mbean metadata for a list of interceptor classes. This strikes > > me as a lot > > more convenient for my purposes than having to construct some long > > interceptor factory list that can be used for any chain. I think > > generating the interceptor chains needs some more thought. > > > > Can you explain what you mean by chain? You're thinking a chain for each > method? You're saying its easier to define a chain for each method > rather > than to define a chain for the whole object?
definitely. Why can't we have both? > There's no reason why not. sure, this is fine, my proposed interceptor design should let you do this easily. I don't quite see how to fit it into your current aop stuff easily. For the moment I am just using the jmx interceptors and they are working fine. One of my points here is that I think the purpose of the InterceptorFilter is to simulate per-method chains (based on the comment "we should cache the results of calling the filter"), and I think actual per-method chains are a much clearer and cleaner implementation. Certainly the current implementation of InvocationFilter is silly, all it does is make 2 method calls instead of one. > > > > Bill, my impression is that you are planning to use your AOP framework > > as-is for the ejb conversion. Is there anything I can do to influence > you > > towards using per-method interceptors from the start? Or do you think > two > > smaller rewrites is a better plan than one larger rewrite? > > > > No where in our entire EJB/J2EE codebase do we use per-method > interceptors. Jmx has had per method interceptors for many months. I'm just putting them to use. > > The use of the AOP Invocation object nor the Interceptor interface > effects > configuration or whether or not there are method chains or not. ?? Can't decipher what you are trying to say here. Thanks david > > Bill > > > > ------------------------------------------------------- > This SF.net email is sponsored by: Etnus, makers of TotalView, The > debugger > for complex code. Debugging C/C++ programs can leave you feeling lost and > > disoriented. TotalView can help you find your way. Available on major > UNIX > and Linux platforms. Try it free. www.etnus.com > _______________________________________________ > Jboss-development mailing list > [EMAIL PROTECTED] > https://lists.sourceforge.net/lists/listinfo/jboss-development > > ------------------------------------------------------- This SF.net email is sponsored by: Etnus, makers of TotalView, The debugger for complex code. Debugging C/C++ programs can leave you feeling lost and disoriented. TotalView can help you find your way. Available on major UNIX and Linux platforms. Try it free. www.etnus.com _______________________________________________ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
