Patches item #760035, was opened at 2003-06-24 20:09 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=376687&aid=760035&group_id=22866
Category: JBossServer Group: v3.2 Status: Open Resolution: None Priority: 5 Submitted By: Rod Burgett (rodburgett) Assigned to: Nobody/Anonymous (nobody) Summary: housekeeping cleanup in LocalJBossServerDomain Initial Comment: Several housekeeping methods are incomplete in o.j.management.j2ee.LocalJBossServerDomain.java. This patch adds new processing to existing housekeeping methods, and refactors those methods into new private methods for readability. Also, a new metod is added to override an empty method from higher in the inheritance heiracrhy. The createService() method is refactored to simply call two new method, private methods: populateFactoryMap () and registerWithCurrentDeployers(). No new processing is added here. The postCreation() method is refactored to simply call two new, private methods: setupJ2EEMBeans() and registerWithController(). The setupJ2EEMBeans() method populates new instance fields with object names for the j2ee server name and jvm name. No new processing is added here. The code in destroyService() method is refactored into a new, private method: cleanupLeftoverMBeans(), and a call to a new method is added: unregisterWithDeployers (). This method represents housekeeping that was previously omitted. A new method is added, postDestruction(), overriding the protected, but empty, postDestruction() method of J2EEManagedObject.java. The code in this method consists of calls to a new method: unregisterWithController(). This method undoes the actions of its counterpart called from postCreation(). Since the J2EE MBeans, set up in postCreation() are unregistered by cleanupLeftoverMBeans(), it is not necessary to undo that here. The refactoring, while not changing any functionality, improves readability by making it clear that the create and destroy methods mirror one another. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=376687&aid=760035&group_id=22866 ------------------------------------------------------- This SF.Net email is sponsored by: INetU Attention Web Developers & Consultants: Become An INetU Hosting Partner. Refer Dedicated Servers. We Manage Them. You Get 10% Monthly Commission! INetU Dedicated Managed Hosting http://www.inetu.net/partner/index.php _______________________________________________ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
