In the process of tracking down a bug I ran into the nasty mail log thing again.  It 
was a dumb idea when I implemented it.  Or rather it was a good idea with HORRIBLE 
tradeoffs.  I wanted to be able to turn on and off conversational logging from the JMX 
Console or some similar tool.  The nasty tradeoffs were: 

a divide between our normal log4j logging and this logging.
a disgusting amount of passing around MailLog references which made the code nasty

We do loose the functionality of a on and off switch but we still can turn 
conversational logging on and off at runtime with a mere log4j Appender and/ or grep 
for "LoggingInputStream" or "WrappedWriter".  Here is my log setup:

(normal with the addition near the end of)
      
              
                     
                     
             
         

             
                   
          <appender-ref ref="JBMAIL"/>    
      

Lastly the bug I tracked down was in AUTH method PLAIN (AUTH PLAIN).  A code change 
had assumed that the parameter to AUTH would have NO spaces after "AUTH " and 
concatanated it.  Acutally AUTH PLAIN takes a parameter after plain which is the users 
BASE64'd password.  This was being concatinated with PLAIN which made any client (such 
as mozilla's thunderbird mail client) just seem to hang.  Bummer.  I fixed the change 
to only kill carriage returns and tabs and the such.  It was MUCH easier after I 
simplified the logging.

Any other thoughts on this?  Objections?  Questions?  Comments?  Social Criticisims?

View the original post : 
http://www.jboss.org/index.html?module=bb&op=viewtopic&p=3829498#3829498

Reply to the post : 
http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=3829498


-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
_______________________________________________
JBoss-Development mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/jboss-development

Reply via email to