Bugs item #1001253, was opened at 2004-07-31 21:32 Message generated for change (Comment added) made by loubyansky You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=376685&aid=1001253&group_id=22866
Category: JBossServer Group: v3.2 >Status: Closed >Resolution: Invalid Priority: 5 Submitted By: Frank Langelage (lafr) >Assigned to: Alexey Loubyansky (loubyansky) Summary: object comparison with '==' Initial Comment: In method org.jboss.ejb.plugins.AbstractInstancePool.importXml(org.w3c.dom.Element) (Line 318) there is a comparison of Booleans with '==' instead of equals. ---------------------------------------------------------------------- >Comment By: Alexey Loubyansky (loubyansky) Date: 2004-08-01 10:16 Message: Logged In: YES user_id=543482 Read the context first. ---------------------------------------------------------------------- Comment By: Frank Langelage (lafr) Date: 2004-07-31 23:34 Message: Logged In: YES user_id=300021 OK, in this special case the Boolean object is constructed fromBoolean.valueOf(), so the comparison with '==' works coorect here. I didn't read the context when submitting the bug. I used the tool FindBugs to inspect the code. But as far as I can see, thefurther mentioned Integer comparisons are suspect. ---------------------------------------------------------------------- Comment By: Scott M Stark (starksm) Date: 2004-07-31 21:45 Message: Logged In: YES user_id=175228 How does this matter? Every Boolean.valueOf return either Boolean.TRUE or Boolean.FALSE so identity comparison is valid. ---------------------------------------------------------------------- Comment By: Frank Langelage (lafr) Date: 2004-07-31 21:35 Message: Logged In: YES user_id=300021 some more: org.jboss.ejb.plugins.cmp.jdbc.bridge.JDBCEntityBridge.init() (line 158) org.jboss.ejb.plugins.cmp.jdbc.bridge.JDBCEntityBridge.loadLoadGroups(org.jboss.ejb.plugins.cmp.jdbc.metadata.JDBCEntityMetaData) (line 961) org.jboss.ejb.plugins.cmp.jdbc.metadata.JDBCOptimisticLockingMetaData.constructLockingField(JDBCEntityMetaData,org.w3c.dom.Element) (line 166) org.jboss.ejb.plugins.cmp.jdbc2.bridge.JDBCEntityBridge2.init() (line 76) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=376685&aid=1001253&group_id=22866 ------------------------------------------------------- This SF.Net email is sponsored by OSTG. Have you noticed the changes on Linux.com, ITManagersJournal and NewsForge in the past few weeks? Now, one more big change to announce. We are now OSTG- Open Source Technology Group. Come see the changes on the new OSTG site. www.ostg.com _______________________________________________ JBoss-Development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
