Bugs item #1046721, was opened at 2004-10-13 17:58 Message generated for change (Comment added) made by starksm You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=376685&aid=1046721&group_id=22866
Category: JBossCX Group: v4.0 Status: Open Resolution: None Priority: 5 Submitted By: Adrian Brock (ejort) Assigned to: Alexey Loubyansky (loubyansky) Summary: DataSource metadata is incomplete/wrong Initial Comment: The DataSource metadata processing is incomplete/wrong. 1) The MBean does not belong in the JBoss JDBC resource adapter. This should neither depend on JMX or CMP. I already have TODOs to remove the current dependencies that have crept in so this RAR can be used outside of the jboss server. Besides, it is possible for db vendors to provide their own resource adapters (cf Firebird) and this service should still work. If it belongs anywhere in the connector module (which I don't think it does) it should be in a top level directory. The created service is logically associated with the connection factory deployment rather than the resource adapter deployment anyway. 2) The metadata/typemapping is not documented in jboss-ds-1_5.dtd Additionally, the whole point of this file is to have a flat namespace, why the metadata/typemapping? There are plans to replace this config with a programmatic javabean style deployment. I'm not sure how you fix this now it has been released in 4.0.0 When I agreed to this, I said I didn't mind the -ds.xml deployer creating the MBean, it is the obvious place to put this configuration. But I said the implementation should be elsewhere, i.e. in the server module (because it uses the CMP metadata) or whatever jdbc abstraction project is created in the future. The service is used by the consumer of the DataSource not the DataSource or the connection factory deployment. ---------------------------------------------------------------------- >Comment By: Scott M Stark (starksm) Date: 2004-11-07 10:11 Message: Logged In: YES user_id=175228 Change the metadata/type-mapping to just type-mapping and document this in the jboss-ds-1_5.dtd. For backward compatibility just maintain the current ConnectionFactoryTemplate.xsl $datasource/metadata/type-mapping and add a $datasource/type-mapping ---------------------------------------------------------------------- Comment By: Alexey Loubyansky (loubyansky) Date: 2004-10-28 04:36 Message: Logged In: YES user_id=543482 I moved the mbeans to cmp just to have all this metadata stuff in one place. What's with metadata/type-mapping? Should it be just type-mapping? Support both (since 4.0.1 is a maintainance release)? Or leave it for now as it is? ---------------------------------------------------------------------- Comment By: Alexey Loubyansky (loubyansky) Date: 2004-10-18 05:57 Message: Logged In: YES user_id=543482 The Firebird issue was fixed (metadata wasn't defined for connection factories). So what needs to be done to fix this is just to move the metadata related MBeans to another package, right? And replace metadata/type-mapping with just metadata or just type-mapping? ---------------------------------------------------------------------- Comment By: Adrian Brock (ejort) Date: 2004-10-18 05:36 Message: Logged In: YES user_id=9459 Ok, so you say it shouldn't be in CMP (which I agree with) and I say it should be in the RAR (which is where it is currently located). I noticed somebody else raised a bug report about it not working with the Firebird rar? ---------------------------------------------------------------------- Comment By: Alexey Loubyansky (loubyansky) Date: 2004-10-18 00:18 Message: Logged In: YES user_id=543482 The type-mapping metadata does not belong to CMP. The metadata is JDBC specific and should be available to any JDBC client. The class hierarchy is in CMP package for historical reasons. That's why I thought it should be in JDBC resource adaptor. 2) metadata is added to the dtd with type ANY for now. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=376685&aid=1046721&group_id=22866 ------------------------------------------------------- This SF.Net email is sponsored by: Sybase ASE Linux Express Edition - download now for FREE LinuxWorld Reader's Choice Award Winner for best database on Linux. http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click _______________________________________________ JBoss-Development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
