Bugs item #1035252, was opened at 2004-09-26 20:20
Message generated for change (Comment added) made by starksm
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=376685&aid=1035252&group_id=22866

Category: Build System
Group: v4.0
>Status: Closed
Resolution: None
Priority: 5
Submitted By: Craig Johannsen (cjohan)
Assigned to: Bill Burke (patriot1burke)
Summary: build.xml incorrect

Initial Comment:
For the AOP annotation example, the build.xml file is
incorrect in several ways:
1.) It does not pick up the jboss version of ant.
2.) It does not find the proper jar files.

The effect is that one runs ant and gets messages about
some ant tasks not found.  Then, when that is fixed,
one gets messages about classes not found, due to the
improperly defined classpaths.

What is the intention of this build file?  Where was it
supposed to find the jars?

Here is an example fix that works only after the user
has built the source by running build.sh:

[EMAIL PROTECTED] annotation]$ diff build_orig.xml
build.xml
3a4,8
>    <property name="rel" value="jboss-4.0.0" />
>    <property name="jboss.lib"
value="../../../../build/output/${rel}/lib" />
>    <property name="jboss.all.lib"
value="../../../../build/output/${rel}/server/all/lib" />
>    <property name="aop.jdk1.5.lib"
value="../../../output/lib" />
>    <property name="thirdparty"
value="../../../../thirdparty" />
6c11
<          <pathelement path="../../../javassist.jar"/>
---
>          <pathelement
path="${jboss.all.lib}/javassist.jar"/>
10c15
<          <pathelement path="../../../trove.jar"/>
---
>          <pathelement
path="${thirdparty}/trove/lib/trove.jar"/>
14c19
<          <pathelement path="../../../concurrent.jar"/>
---
>          <pathelement
path="${jboss.lib}/concurrent.jar"/>
18c23
<          <pathelement path="../../../jboss-common.jar"/>
---
>          <pathelement
path="${jboss.lib}/jboss-common.jar"/>
22c27,28
<          <pathelement
path="../../../jboss-aop-jdk15.jar"/>
---
>          <pathelement
path="${aop.jdk1.5.lib}/jboss-aop-jdk15.jar"/>
>        <pathelement
path="${aop.jdk1.5.lib}/jboss-aop.jar"/>
26c32
<          <pathelement path="../../../qdox.jar"/>
---
>          <pathelement path="${thirdparty}/qdox.jar"/>

Except javassist.jar was missing, so I'm not positive
the above fix is completely correct.  Copying the
javassist.jar from RC1 resulted in a NoClassDefFoundError:
compile:
     [aopc] [debug] jboss.aop.class.path is NULL
     [aopc] [debug] jboss.aop.search.classpath: 'null' true
     [aopc] [debug] jboss.aop.path:
/home/craigj/jboss-4.0.0-src/aop/docs/examples/annotation/jboss-aop.xml
     [aopc] jboss.aop.path[0]:
/home/craigj/jboss-4.0.0-src/aop/docs/examples/annotation/jboss-aop.xml
     [aopc] [deploying]
file:/home/craigj/jboss-4.0.0-src/aop/docs/examples/annotation/jboss-aop.xml
     [aopc] [deploy] <bind>
file:/home/craigj/jboss-4.0.0-src/aop/docs/examples/annotation/jboss-aop.xml
     [aopc] [deploy] <bind>
file:/home/craigj/jboss-4.0.0-src/aop/docs/examples/annotation/jboss-aop.xml
     [aopc] [deploy] <bind>
file:/home/craigj/jboss-4.0.0-src/aop/docs/examples/annotation/jboss-aop.xml
     [aopc] Exception in thread "main"
java.lang.NoClassDefFoundError:
javassist/bytecode/AnnotationsAttribute
     [aopc]     at
org.jboss.aop.AspectManager.translate(AspectManager.java:470)
     [aopc]     at
org.jboss.aop.AspectManager.transform(AspectManager.java:404)
     [aopc]     at
org.jboss.aop.standalone.Compiler.compileFile(Compiler.java:201)
     [aopc]     at
org.jboss.aop.standalone.Compiler.compile(Compiler.java:162)
     [aopc]     at
org.jboss.aop.standalone.Compiler.main(Compiler.java:61)




----------------------------------------------------------------------

Comment By: Scott M Stark (starksm)
Date: 2004-12-29 12:51

Message:
Logged In: YES 
user_id=175228

All issues have been moved to http://jira.jboss.com. Existing
issues have been moved. New issues will be closed with this
canned reponse.

----------------------------------------------------------------------

Comment By: Scott M Stark (starksm)
Date: 2004-11-07 10:35

Message:
Logged In: YES 
user_id=175228

Bill, can you take a look at this an reassign it if needed.

----------------------------------------------------------------------

Comment By: Craig Johannsen (cjohan)
Date: 2004-09-26 20:57

Message:
Logged In: YES 
user_id=47444

Sorry to keep adding comments to my own bug report, but I
keep noticing things I forgot to mention.

NOTE: The attached patch only fixes the classpaths -- it
does not fix the problem of finding the correct Ant instance
nor does it fix the problem of building the jars15 target
automatically, though the latter should be easy to add.

----------------------------------------------------------------------

Comment By: Craig Johannsen (cjohan)
Date: 2004-09-26 20:52

Message:
Logged In: YES 
user_id=47444

CORRECTION:  javasisist.jar is not missing.  It was moved to
the thirdparty directory.

I neglected above to mention that for the annotation example
to work, one must build the "jars15" target at the top of
the aop directory.  This should either be done automatically
or else be properly documented.

Attached is a build.xml patch (a diff file) for the
annotation example that actually works (once the user has
run build.sh in the build directory).

----------------------------------------------------------------------

Comment By: Craig Johannsen (cjohan)
Date: 2004-09-26 20:22

Message:
Logged In: YES 
user_id=47444

Changed bug summary to make it describe the problem better.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=376685&aid=1035252&group_id=22866


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/
_______________________________________________
JBoss-Development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/jboss-development

Reply via email to