Change approach to removing configuration blocks
------------------------------------------------
Key: JBMAIL-20
URL: http://jira.jboss.com/jira/browse/JBMAIL-20
Project: JBoss Mail
Type: Task
Components: build
Versions: 1.0-M3
Reporter: Andrew Oliver
Assigned to: Andrew Oliver
Priority: Minor
Fix For: 1.0-M3
presently we do this:
<filterreader classname="org.jboss.cheese.filters.StripBetweenFilter"
classpathref="build.classpath">
<param name="condition" value="valueNot=${smtp.enabled}"/>
<param name="begin" value="/** SMTP PROTOCOL"/>
<param name="end" value="SMTP PROTOCOL **/"/>
<param name="stripMarker" value="true"/>
</filterreader>
/** SMTP PROTOCOL
<!--
SMTPProtocol is used for a "Server" instance. This is an unencrypted
protocol
-->
<mbean code="org.jboss.mail.smtp.SMTPProtocol"
name="jboss.mail:type=MailServices,name=SMTPProtocol">
<depends>jboss.mail:type=MailServices,name=MailListener</depends>
<depends>jboss.mail:type=MailServices,name=MailListJMSListener</depends>
<depends>jboss.mail:type=MailServices,name=NukesPosterJMSListener</depends>
<depends>jboss.mail:type=MailServices,name=UserRepository,uimanageable=true</depends>
<depends
optional-attribute-name="DomainGroup">jboss.mail:type=MailServices,name=DomainGroup,group=Local</depends>
...
SMTP PROTOCOL **/
instead, we should do
<filterreader classname="org.jboss.cheese.filters.StripCommentFilter"
classpathref="build.classpath">
<param name="condition" value="value=${smtp.enabled}"/>
<param name="begin" value="<!-- uncomment for SMTP PROTOCOL
support"/>
<param name="end" value="SMTP PROTOCOL -->"/>
</filterreader>
<!--
SMTPProtocol is used for a "Server" instance. This is an unencrypted
protocol
-->
<!-- uncomment for SMTP PROTOCOL support
<mbean code="org.jboss.mail.smtp.SMTPProtocol"
name="jboss.mail:type=MailServices,name=SMTPProtocol">
<depends>jboss.mail:type=MailServices,name=MailListener</depends>
<depends>jboss.mail:type=MailServices,name=MailListJMSListener</depends>
<depends>jboss.mail:type=MailServices,name=NukesPosterJMSListener</depends>
<depends>jboss.mail:type=MailServices,name=UserRepository,uimanageable=true</depends>
<depends
optional-attribute-name="DomainGroup">jboss.mail:type=MailServices,name=DomainGroup,group=Local</depends>
SMTP PROTOCOL -->
Implementing the stripcomment filter should be trivial.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt
_______________________________________________
JBoss-Development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/jboss-development
