[ http://jira.jboss.com/jira/browse/JBAS-597?page=history ]
Adrian Brock updated JBAS-597:
------------------------------
Description:
SourceForge Submitter: rodburgett .
The purpose of this patch is to improve the cleanup
operations of the deployers in org.jboss.deployment
package, specifically the Main and SAR deployers.
The primary change to the MainDeployer is to
supplement the shutdown method by nulling out
references and clearing containers.
Also, error messages in the stop(DeploymentInfo) and
destroy(DeploymentInfo) methods were updated to
indicate which method produced the messsage.
Finally in the MainDeployer, the init(DeploymentInfo)
method included a suspicious synchronized block. The
target code for synchronization adds an entry to the
deploymentMap field, but the subject of the
synchronized statement is a different field,
deploymentList. It is possible that this mismatch is
intentional, but it suggests to me a cut-n-paste error.
The SARDeployer patch file adds a stopService() method
to null out internal references that were initialized in
startService(). Prior to updating these references,
super.stopService() is called.
was:
SourceForge Submitter: rodburgett .
The purpose of this patch is to improve the cleanup
operations of the deployers in org.jboss.deployment
package, specifically the Main and SAR deployers.
The primary change to the MainDeployer is to
supplement the shutdown method by nulling out
references and clearing containers.
Also, error messages in the stop(DeploymentInfo) and
destroy(DeploymentInfo) methods were updated to
indicate which method produced the messsage.
Finally in the MainDeployer, the init(DeploymentInfo)
method included a suspicious synchronized block. The
target code for synchronization adds an entry to the
deploymentMap field, but the subject of the
synchronized statement is a different field,
deploymentList. It is possible that this mismatch is
intentional, but it suggests to me a cut-n-paste error.
The SARDeployer patch file adds a stopService() method
to null out internal references that were initialized in
startService(). Prior to updating these references,
super.stopService() is called.
Environment:
Component: JMX
> housekeeping in Main/SAR deployers
> ----------------------------------
>
> Key: JBAS-597
> URL: http://jira.jboss.com/jira/browse/JBAS-597
> Project: JBoss Application Server
> Type: Bug
> Components: JMX
> Versions: JBossAS-3.2.6 Final
> Reporter: SourceForge User
> Assignee: Scott M Stark
>
>
> SourceForge Submitter: rodburgett .
> The purpose of this patch is to improve the cleanup
> operations of the deployers in org.jboss.deployment
> package, specifically the Main and SAR deployers.
> The primary change to the MainDeployer is to
> supplement the shutdown method by nulling out
> references and clearing containers.
> Also, error messages in the stop(DeploymentInfo) and
> destroy(DeploymentInfo) methods were updated to
> indicate which method produced the messsage.
> Finally in the MainDeployer, the init(DeploymentInfo)
> method included a suspicious synchronized block. The
> target code for synchronization adds an entry to the
> deploymentMap field, but the subject of the
> synchronized statement is a different field,
> deploymentList. It is possible that this mismatch is
> intentional, but it suggests to me a cut-n-paste error.
> The SARDeployer patch file adds a stopService() method
> to null out internal references that were initialized in
> startService(). Prior to updating these references,
> super.stopService() is called.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
JBoss-Development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/jboss-development
