build failed due to error in getServerSessionPool
-------------------------------------------------
Key: JBAS-1521
URL: http://jira.jboss.com/jira/browse/JBAS-1521
Project: JBoss Application Server
Type: Patch
Components: EJBs
Reporter: Marcin Mieszek
Priority: Blocker
Build of module jboss-head failed due to:
D:\jboss\jboss-head\ejb3\src\main\org\jboss\ejb3\mdb\ConsumerContainer.java:560:
getServerSessionPool(javax.jms.Destination,javax.jms.Connection,int,int,long,boolean,int,boolean,javax.jms.MessageListener)
in org.jboss.jms.asf.ServerSessionPoolFactory cannot be applied to
(javax.jms.Connection,int,int,int,boolean,int,boolean,javax.jms.MessageListener)
pool = factory.getServerSessionPool(connection,
config.getMinPoolSize(), config.getMaxPoolSize(), config.getKeepAlive(),
isTransacted, ack, !isContainerManagedTx || isNotSupportedTx, listener);
^
D:\jboss\jboss-head\ejb3\src\main\org\jboss\ejb3\mdb\MDB.java:421:
getServerSessionPool(javax.jms.Destination,javax.jms.Connection,int,int,long,boolean,int,boolean,javax.jms.MessageListener)
in org.jboss.jms.asf.ServerSessionPoolFactory cannot be applied to
(javax.jms.Connection,int,int,int,boolean,int,boolean,javax.jms.MessageListener)
pool = factory.getServerSessionPool(connection,
config.getMinPoolSize(), config.getMaxPoolSize(), config.getKeepAlive(),
isTransacted, ack, !isContainerManagedTx || isNotSupportedTx, listener);
^
I created a patch for
jboss-head\ejb3\src\main\org\jboss\ejb3\mdb\ConsumerContainer.java:
--- cvs.java 2005-02-25 03:40:04.000000000 +0100
+++ local.java 2005-02-25 03:40:30.546875000 +0100
@@ -373,7 +373,7 @@
Method methodMessage = (Method) advisedMethods.get(hash);
// set up the server session pool
- ServerSessionPool serverSessionPool =
createSessionPool(qConnection,
+ ServerSessionPool serverSessionPool = createSessionPool(queue,
qConnection,
true, // tx
acknowledgeMode.ordinal(),
listener,
@@ -483,7 +483,7 @@
Method methodMessage = (Method) advisedMethods.get(hash);
// set up the server session pool
- ServerSessionPool serverSessionPool =
createSessionPool(tConnection,
+ ServerSessionPool serverSessionPool = createSessionPool(topic,
tConnection,
true, // tx
acknowledgeMode.ordinal(),
listener,
@@ -522,10 +522,8 @@
/**
* Create a server session pool for the given connection.
*
+ * @param destination The destination.
* @param connection The connection to use.
- * @param minSession The minumum number of sessions
- * @param maxSession The maximum number of sessions.
- * @param keepAlive The time to keep sessions alive
* @param isTransacted True if the sessions are transacted.
* @param ack The session acknowledgement mode.
* @param listener The message listener.
@@ -534,7 +532,8 @@
* @throws javax.naming.NamingException Description of Exception
*/
protected ServerSessionPool
- createSessionPool(final Connection connection,
+ createSessionPool(final Destination destination,
+ final Connection connection,
final boolean isTransacted,
int ack,
final MessageListener listener,
@@ -557,7 +556,7 @@
boolean isNotSupportedTx = txType ==
TransactionAttributeType.NOTSUPPORTED;
// the create the pool
- pool = factory.getServerSessionPool(connection,
config.getMinPoolSize(), config.getMaxPoolSize(), config.getKeepAlive(),
isTransacted, ack, !isContainerManagedTx || isNotSupportedTx, listener);
+ pool = factory.getServerSessionPool(destination, connection,
config.getMinPoolSize(), config.getMaxPoolSize(), config.getKeepAlive(),
isTransacted, ack, !isContainerManagedTx || isNotSupportedTx, listener);
}
finally
{
Patch for jboss-head\ejb3\src\main\org\jboss\ejb3\mdb\MDB.java is:
--- cvs.java 2005-02-25 03:47:14.453125000 +0100
+++ local.java 2005-02-25 03:47:32.890625000 +0100
@@ -272,7 +272,7 @@
// set up the server session pool
- serverSessionPool = createSessionPool(qConnection,
+ serverSessionPool = createSessionPool(queue, qConnection,
true, // tx
acknowledgeMode.ordinal(),
new MessageListenerImpl(this));
@@ -344,7 +344,7 @@
jndiSuffix);
// set up the server session pool
- serverSessionPool = createSessionPool(tConnection,
+ serverSessionPool = createSessionPool(topic, tConnection,
true, // tx
acknowledgeMode.ordinal(),
new MessageListenerImpl(this));
@@ -388,10 +388,8 @@
/**
* Create a server session pool for the given connection.
+ * @param destination The destination.
* @param connection The connection to use.
- * @param minSession The minumum number of sessions
- * @param maxSession The maximum number of sessions.
- * @param keepAlive The time to keep sessions alive
* @param isTransacted True if the sessions are transacted.
* @param ack The session acknowledgement mode.
* @param listener The message listener.
@@ -400,7 +398,8 @@
* @throws NamingException Description of Exception
*/
protected ServerSessionPool
- createSessionPool(final Connection connection,
+ createSessionPool(final Destination destination,
+ final Connection connection,
final boolean isTransacted,
int ack,
final MessageListener listener)
@@ -418,7 +417,7 @@
context.lookup(config.getServerSessionPoolFactoryJNDI());
// the create the pool
- pool = factory.getServerSessionPool(connection,
config.getMinPoolSize(), config.getMaxPoolSize(), config.getKeepAlive(),
isTransacted, ack, !isContainerManagedTx || isNotSupportedTx, listener);
+ pool = factory.getServerSessionPool(destination, connection,
config.getMinPoolSize(), config.getMaxPoolSize(), config.getKeepAlive(),
isTransacted, ack, !isContainerManagedTx || isNotSupportedTx, listener);
}
finally
{
As I've just started contributing to jboss, please let me know if the format of
my patch is ok and if it is useful.
Best regards,
Marcin Mieszek
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
JBoss-Development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/jboss-development
